Skip to content

Use gzip (.gz) instead of bzip2 (.bz2) to compress logs#1408

Merged
mvidner merged 3 commits intomasterfrom
use-gzip-not-bzip2
Jun 28, 2024
Merged

Use gzip (.gz) instead of bzip2 (.bz2) to compress logs#1408
mvidner merged 3 commits intomasterfrom
use-gzip-not-bzip2

Conversation

@mvidner
Copy link
Copy Markdown
Contributor

@mvidner mvidner commented Jun 28, 2024 •
edited
Loading

Problem

Quoting #1378:

GitHub does not allow attaching bzip2 files. In order to make error reporting easier, agama logs store should use a different format (e.g., .gz and .tgz are supported). Otherwise, you need to uncompress and compress the logs again before submitting them.

Solution

Use gzip and .gz instead.

Testing

  • Tested manually

Screenshots

If the fix affects the UI attach some screenshots here.

@mvidner
Use gzip (.gz) instead of bzip2 (.bz2) to compress logs (gh##1378)
9f24154 
so that they can be attached to GitHub issues.

Note that bzip2 is still used for source tarballs and PO tarballs
at *development* time,
but AFAIK no longer used at *run* time,
so the dependency is kept in .github/workflows but not in .spec
@mvidner mvidner force-pushed the use-gzip-not-bzip2 branch from 2e9447d to 3d28bf0 Compare June 28, 2024 06:24
imobachgs
imobachgs reviewed Jun 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Please, add a changelog entry referencing the original bug. Otherwise, it looks good to me!

PS: thanks for the ripgrep fix too :-)

@mvidner mvidner force-pushed the use-gzip-not-bzip2 branch from 3d28bf0 to 0b7ccea Compare June 28, 2024 06:59
@mvidner mvidner merged commit accf894 into master Jun 28, 2024
@mvidner mvidner deleted the use-gzip-not-bzip2 branch June 28, 2024 07:22
@imobachgs imobachgs mentioned this pull request Jun 28, 2024
Closed
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
Merged
imobachgs added a commit that referenced this pull request Sep 20, 2024
@imobachgs
Update to release 10 (#1622)
574a1a5 
Prepare for releasing Agama 10·

* #1263
* #1330
* #1407
* #1408
* #1410
* #1411
* #1412
* #1416
* #1417
* #1419
* #1420
* #1421
* #1422
* #1423
* #1424
* #1425
* #1428
* #1429
* #1430
* #1431
* #1432
* #1433
* #1436
* #1437
* #1438
* #1439
* #1440
* #1441
* #1443
* #1444
* #1445
* #1449
* #1450
* #1451
* #1452
* #1453
* #1454
* #1455
* #1456
* #1457
* #1459
* #1460
* #1462
* #1464
* #1465
* #1466
* #1467
* #1468
* #1469
* #1470
* #1471
* #1472
* #1473
* #1475
* #1476
* #1477
* #1478
* #1479
* #1480
* #1481
* #1482
* #1483
* #1484
* #1485
* #1486
* #1487
* #1488
* #1489
* #1491
* #1492
* #1493
* #1494
* #1496
* #1497
* #1498
* #1499
* #1500
* #1501
* #1502
* #1503
* #1504
* #1505
* #1506
* #1507
* #1508
* #1510
* #1511
* #1512
* #1513
* #1514
* #1515
* #1516
* #1517
* #1518
* #1519
* #1520
* #1522
* #1523
* #1524
* #1525
* #1526
* #1527
* #1528
* #1529
* #1530
* #1531
* #1532
* #1533
* #1534
* #1535
* #1536
* #1537
* #1540
* #1541
* #1543
* #1544
* #1545
* #1546
* #1547
* #1548
* #1549
* #1550
* #1552
* #1553
* #1554
* #1555
* #1556
* #1557
* #1558
* #1559
* #1560
* #1562
* #1563
* #1565
* #1566
* #1567
* #1568
* #1569
* #1570
* #1571
* #1572
* #1573
* #1574
* #1575
* #1576
* #1577
* #1578
* #1579
* #1580
* #1581
* #1583
* #1584
* #1585
* #1586
* #1587
* #1588
* #1589
* #1590
* #1591
* #1592
* #1593
* #1596
* #1597
* #1598
* #1600
* #1602
* #1605
* #1606
* #1607
* #1608
* #1610
* #1611
* #1612
* #1613
* #1614
* #1619
* #1620
* #1621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mvidner @imobachgs