feat: add AutoYaST error reporting by jreidinger · Pull Request #1476 · agama-project/agama

jreidinger · 2024-07-18T08:07:10Z

Problem

Autoyast conversion script can try to open ui for reporting errors or ask questions.

Solution

Monkey patch it to use agama question mechanism. This change tries to cover the most common cases.
It also needs to implement generic Question with Password react component.
And last but not least during manual testing few issues are revealed and fixed. Also as part of change listing of all question was fixed to really show only unanswered ones and optimize it to use ObjectManager methods.

Testing

For testing CLI for asking this command is used:

agama questions ask < data.json

For testing autoyast questions it uses encrypted autoyast profile that ask for password and also report issue when password is wrong:

agama profile autoyast ftp://pong.suse.cz/autoinst_enc.xml

lslezak

👍

service/lib/agama/autoyast/report_patching.rb

…uestion is created

Co-authored-by: Martin Vidner <mvidner@suse.cz>

web/src/components/questions/QuestionWithPassword.jsx

rust/agama-cli/src/questions.rs

imobachgs · 2024-07-23T08:14:52Z

rust/agama-cli/src/questions.rs

    let created_question = client.create_question(&question).await?;
-    let answer = client.get_answer(created_question.generic.id).await?;
+    let Some(id) = created_question.generic.id else {
+        return Err(ServiceError::QuestionNotExist(0));


What does that '0' mean? It looks like the error is not exactly that the question does not exist.

To be honest this should not happen as it is assigned in that create_question from created question path. I am not sure if we should have something like Programatic error or something that for cases which should not happen and user cannot do naything with it

imobachgs · 2024-07-23T08:18:25Z

rust/agama-lib/src/questions/model.rs

 pub struct GenericQuestion {
-    pub id: u32,
+    /// id is optional as newly created questions does not have it assigned
+    pub id: Option<u32>,


If we get rid of D-Bus in the future, we might consider using an uuid instead of dealing with an Option. But that's out of scope.

rust/agama-server/src/questions/web.rs

imobachgs · 2024-07-23T08:29:45Z

service/lib/agama/autoyast/report_patching.rb

+# rubocop:disable Lint/UnusedMethodArgument
+module Yast2
+  # :nodoc:
+  class Popup


I can see some duplication.

yeah, I forget to remove it

imobachgs · 2024-07-23T08:32:28Z

service/lib/agama/autoyast/report_patching.rb

+    def run
+      # at first construct agama question to display.
+      text = @label
+      question = {


Asking the question seems like a repetitive process. It may not be needed by now, but we might consider having a helper method/class to do so.

service/package/rubygem-agama-yast.changes

web/src/components/questions/QuestionWithPassword.jsx

Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com> Co-authored-by: David Díaz <1691872+dgdavid@users.noreply.github.com>

imobachgs · 2024-07-23T14:05:28Z

Commit fc249f8 introduces a few improvements to the tests:

If you do not need side-effects (using useEffect or interacting with the UI), you do not need the tests to be async.
If the test is not async, you should replace find* (which are async) with query*.
Testing that the password input is there is kind of redundant (you are using it in the following test).
If you do not need the client, prefer plainRender (specific to Agama).

web/src/components/questions/QuestionWithPassword.test.jsx

imobachgs

Please, take into account @dgdavid's comment about the test description and you can merge.

web/src/components/questions/QuestionWithPassword.test.jsx

Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com> Co-authored-by: David Díaz <1691872+dgdavid@users.noreply.github.com>

jreidinger · 2024-07-23T16:13:29Z

There is some troubles with PRG cluster affecting also opensuse services. So tests are red due to failed to load testing container. Will merge even with it as previously it was green and change is just some text changes.

Prepare for releasing Agama 10· * #1263 * #1330 * #1407 * #1408 * #1410 * #1411 * #1412 * #1416 * #1417 * #1419 * #1420 * #1421 * #1422 * #1423 * #1424 * #1425 * #1428 * #1429 * #1430 * #1431 * #1432 * #1433 * #1436 * #1437 * #1438 * #1439 * #1440 * #1441 * #1443 * #1444 * #1445 * #1449 * #1450 * #1451 * #1452 * #1453 * #1454 * #1455 * #1456 * #1457 * #1459 * #1460 * #1462 * #1464 * #1465 * #1466 * #1467 * #1468 * #1469 * #1470 * #1471 * #1472 * #1473 * #1475 * #1476 * #1477 * #1478 * #1479 * #1480 * #1481 * #1482 * #1483 * #1484 * #1485 * #1486 * #1487 * #1488 * #1489 * #1491 * #1492 * #1493 * #1494 * #1496 * #1497 * #1498 * #1499 * #1500 * #1501 * #1502 * #1503 * #1504 * #1505 * #1506 * #1507 * #1508 * #1510 * #1511 * #1512 * #1513 * #1514 * #1515 * #1516 * #1517 * #1518 * #1519 * #1520 * #1522 * #1523 * #1524 * #1525 * #1526 * #1527 * #1528 * #1529 * #1530 * #1531 * #1532 * #1533 * #1534 * #1535 * #1536 * #1537 * #1540 * #1541 * #1543 * #1544 * #1545 * #1546 * #1547 * #1548 * #1549 * #1550 * #1552 * #1553 * #1554 * #1555 * #1556 * #1557 * #1558 * #1559 * #1560 * #1562 * #1563 * #1565 * #1566 * #1567 * #1568 * #1569 * #1570 * #1571 * #1572 * #1573 * #1574 * #1575 * #1576 * #1577 * #1578 * #1579 * #1580 * #1581 * #1583 * #1584 * #1585 * #1586 * #1587 * #1588 * #1589 * #1590 * #1591 * #1592 * #1593 * #1596 * #1597 * #1598 * #1600 * #1602 * #1605 * #1606 * #1607 * #1608 * #1610 * #1611 * #1612 * #1613 * #1614 * #1619 * #1620 * #1621

jreidinger added 2 commits July 18, 2024 09:44

initial version of report patching

bdc3bbc

add readme for agama-yast with hint how to deploy modified gem

fb76036

lslezak reviewed Jul 18, 2024

View reviewed changes

mvidner reviewed Jul 18, 2024

View reviewed changes

service/lib/agama/autoyast/report_patching.rb Outdated Show resolved Hide resolved

jreidinger and others added 15 commits July 18, 2024 14:20

fix file loading

ddd18bf

make rubocop happy

d2a7391

fix returning correct question and add tracing to see which kind of q…

747ee38

…uestion is created

clarify format of questions and answers

4a7ece4

fix superclass

c5494e2

fixes from testing

f1dc311

fix getting answer

d92deef

use correct property names

4d8c0ce

fix questions list to list only unanswered ones

7e550a7

implement general Question with Dialog component

9deacdb

fix path for deleting question

6262156

fix parsing of result

78d997c

Apply suggestions from code review

7879a7c

Co-authored-by: Martin Vidner <mvidner@suse.cz>

Merge remote-tracking branch 'origin/master' into ay_errors

e4c74dc

do not require id for newly created question

b7e1a9e

jreidinger marked this pull request as ready for review July 22, 2024 15:25

jreidinger changed the title ~~initial version of report patching~~ Autoyast Error Reporting Jul 22, 2024

changes

85a7159

dgdavid reviewed Jul 23, 2024

View reviewed changes

web/src/components/questions/QuestionWithPassword.jsx Outdated Show resolved Hide resolved

imobachgs reviewed Jul 23, 2024

View reviewed changes

jreidinger and others added 6 commits July 23, 2024 11:03

Apply suggestions from code review

c44f3af

Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com> Co-authored-by: David Díaz <1691872+dgdavid@users.noreply.github.com>

introduce internal error

2e9d7e7

remove duplicite popup now

2d7fff4

fix formatting

20ea50a

add test for question with password component

097f14f

relax condition of products test to not fail when we change product

33f7c75

jreidinger and others added 3 commits July 23, 2024 14:39

fix formatting

8bc9b1b

Merge remote-tracking branch 'origin/master' into ay_errors

ce03cfc

test(web): simplify QuestionWithPassword tests

fc249f8

dgdavid reviewed Jul 23, 2024

View reviewed changes

web/src/components/questions/QuestionWithPassword.test.jsx Outdated Show resolved Hide resolved

imobachgs approved these changes Jul 23, 2024

View reviewed changes

web/src/components/questions/QuestionWithPassword.test.jsx Outdated Show resolved Hide resolved

dgdavid reviewed Jul 23, 2024

View reviewed changes

web/src/components/questions/QuestionWithPassword.test.jsx Outdated Show resolved Hide resolved

imobachgs changed the title ~~Autoyast Error Reporting~~ feat: add AutoYaST error reporting Jul 23, 2024

Apply suggestions from code review

5cd74da

Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com> Co-authored-by: David Díaz <1691872+dgdavid@users.noreply.github.com>

jreidinger merged commit ce0c770 into master Jul 23, 2024

jreidinger deleted the ay_errors branch July 23, 2024 16:13

imobachgs mentioned this pull request Sep 20, 2024

Update to release 10 #1622

Merged

Conversation

jreidinger commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Testing

Uh oh!

lslezak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imobachgs Jul 23, 2024

Choose a reason for hiding this comment

Uh oh!

jreidinger Jul 23, 2024

Choose a reason for hiding this comment

Uh oh!

imobachgs Jul 23, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

imobachgs Jul 23, 2024

Choose a reason for hiding this comment

Uh oh!

jreidinger Jul 23, 2024

Choose a reason for hiding this comment

Uh oh!

imobachgs Jul 23, 2024

Choose a reason for hiding this comment

Uh oh!

jreidinger Jul 23, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imobachgs commented Jul 23, 2024

Uh oh!

Uh oh!

imobachgs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jreidinger commented Jul 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jreidinger commented Jul 18, 2024 •

edited

Loading