Skip to content

Revert "Early finish fix"#1546

Merged
jreidinger merged 1 commit intomasterfrom
revert-1544-early_finish_fix
Aug 20, 2024
Merged

Revert "Early finish fix"#1546
jreidinger merged 1 commit intomasterfrom
revert-1544-early_finish_fix

Conversation

@jreidinger
Copy link
Copy Markdown
Contributor

Reverts #1544

The change is wrong as it was tested/debugged against old version of backend that does not have afef47b ... The result is that new sources are now broken.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 71.298%. remained the same
when pulling 7d3be12 on revert-1544-early_finish_fix
into 5f2b96b on master.

Copy link
Copy Markdown
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreidinger jreidinger merged commit f1187eb into master Aug 20, 2024
@jreidinger jreidinger deleted the revert-1544-early_finish_fix branch August 20, 2024 06:32
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants