Skip to content

feat(http): implement get answer and delete question#1453

Merged
jreidinger merged 6 commits intomasterfrom
ask_question_http
Jul 11, 2024
Merged

feat(http): implement get answer and delete question#1453
jreidinger merged 6 commits intomasterfrom
ask_question_http

Conversation

@jreidinger
Copy link
Copy Markdown
Contributor

Problem

Currently there is no way how to get answer for asked question ( service do it invisible on dbus ) and also delete is not exposed ( same case that services do it hidden on dbus ).

Solution

Implement DELETE /questions/:id and GET /questions/:id/answer HTTP calls.

@jreidinger jreidinger marked this pull request as ready for review July 10, 2024 20:15
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments. Otherwise, it looks good to me.

jreidinger and others added 2 commits July 11, 2024 10:45
Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreidinger jreidinger merged commit b450375 into master Jul 11, 2024
@jreidinger jreidinger deleted the ask_question_http branch July 11, 2024 10:38
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants