Skip to content

Drop .package-lock.json#1576

Merged
imobachgs merged 1 commit intoagama-project:masterfrom
bmwiedemann:reproducible
Sep 5, 2024
Merged

Drop .package-lock.json#1576
imobachgs merged 1 commit intoagama-project:masterfrom
bmwiedemann:reproducible

Conversation

@bmwiedemann
Copy link
Copy Markdown
Contributor

Drop (leftover?) .package-lock.json for reproducible builds

Problem

The .package-lock.json file containted a random TCP port number, which made build results vary.

Solution

We drop the file. If that is not appropriate, we could replace the random number with a constant.

Testing

  • tested that it builds reproducibly.

@imobachgs imobachgs requested a review from lslezak September 5, 2024 07:10
@imobachgs imobachgs merged commit 4153b45 into agama-project:master Sep 5, 2024
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants