feat(storage): initial version of config search#1560
Merged
joseivanlopez merged 5 commits intoagama-project:masterfrom Sep 4, 2024
Merged
feat(storage): initial version of config search#1560joseivanlopez merged 5 commits intoagama-project:masterfrom
joseivanlopez merged 5 commits intoagama-project:masterfrom
Conversation
be32830 to
c320ee7
Compare
21f27a5 to
040f758
Compare
joseivanlopez
commented
Sep 3, 2024
| } | ||
| } | ||
| }, | ||
| "search": { |
Contributor
Author
There was a problem hiding this comment.
The document auto_storage suggests two possible syntaxes for the search condition:
Option A:
{
"search": {
"condition": { "property": "name", "value": "/dev/sda2" }
}
}Option B:
{
"search": {
"condition": { "name": "/dev/sda2" }
}
}The option B was chosen in this PR because the following reasons:
- It is shorter and more expressive.
{"size": { "greater": "1 GiB" } } vs
{ "property": "size", "value": "1 GiB", "operator": "greater" }
-
It is easier to validate the possible properties and their values in the schema.
-
It is easier to define different sets of searches in the schema. For example, a drive could be searched by name, size and model, but a partition only by name and size.
Contributor
Author
There was a problem hiding this comment.
There is a third option to be discussed. It consists on directly use the condition without wrapping with a condition property:
{
"search": {
"name": "/dev/vda1",
"ifNotFound": "skip"
}
}
{
"search": {
"and": [
{ "size": { "greater": "10 GiB"} },
{ "size": { "less": "50 GiB"} }
]
}
}
Merged
imobachgs
added a commit
that referenced
this pull request
Sep 20, 2024
Prepare for releasing Agama 10· * #1263 * #1330 * #1407 * #1408 * #1410 * #1411 * #1412 * #1416 * #1417 * #1419 * #1420 * #1421 * #1422 * #1423 * #1424 * #1425 * #1428 * #1429 * #1430 * #1431 * #1432 * #1433 * #1436 * #1437 * #1438 * #1439 * #1440 * #1441 * #1443 * #1444 * #1445 * #1449 * #1450 * #1451 * #1452 * #1453 * #1454 * #1455 * #1456 * #1457 * #1459 * #1460 * #1462 * #1464 * #1465 * #1466 * #1467 * #1468 * #1469 * #1470 * #1471 * #1472 * #1473 * #1475 * #1476 * #1477 * #1478 * #1479 * #1480 * #1481 * #1482 * #1483 * #1484 * #1485 * #1486 * #1487 * #1488 * #1489 * #1491 * #1492 * #1493 * #1494 * #1496 * #1497 * #1498 * #1499 * #1500 * #1501 * #1502 * #1503 * #1504 * #1505 * #1506 * #1507 * #1508 * #1510 * #1511 * #1512 * #1513 * #1514 * #1515 * #1516 * #1517 * #1518 * #1519 * #1520 * #1522 * #1523 * #1524 * #1525 * #1526 * #1527 * #1528 * #1529 * #1530 * #1531 * #1532 * #1533 * #1534 * #1535 * #1536 * #1537 * #1540 * #1541 * #1543 * #1544 * #1545 * #1546 * #1547 * #1548 * #1549 * #1550 * #1552 * #1553 * #1554 * #1555 * #1556 * #1557 * #1558 * #1559 * #1560 * #1562 * #1563 * #1565 * #1566 * #1567 * #1568 * #1569 * #1570 * #1571 * #1572 * #1573 * #1574 * #1575 * #1576 * #1577 * #1578 * #1579 * #1580 * #1581 * #1583 * #1584 * #1585 * #1586 * #1587 * #1588 * #1589 * #1590 * #1591 * #1592 * #1593 * #1596 * #1597 * #1598 * #1600 * #1602 * #1605 * #1606 * #1607 * #1608 * #1610 * #1611 * #1612 * #1613 * #1614 * #1619 * #1620 * #1621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow using a search section in the storage JSON config for drives and partitions, according to the auto_storage document. For now, the search only supports:
Examples:
{ "search": "/dev/disk/by-id/ata-Micron_1100_SATA_512GB_1652155452D8" }{ "search": { "condition": { "name": "/dev/vdc1" }, "ifNotFound": "skip" } }