Skip to content

refactor(web): drop issues context#1470

Merged
imobachgs merged 3 commits intomasterfrom
drop-issues-context
Jul 17, 2024
Merged

refactor(web): drop issues context#1470
imobachgs merged 3 commits intomasterfrom
drop-issues-context

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

Use TanStack to replace IssuesProvider. It is related to #1439 and #1452.

@imobachgs imobachgs marked this pull request as ready for review July 17, 2024 08:07
Copy link
Copy Markdown
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for moving this forward ⏩

if (event.type === "IssuesChanged") {
const path = event.path;
const scope = scopesFromPath[path];
// TODO: use setQueryData because all the issues are included in the event
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@imobachgs imobachgs merged commit 53eb89e into master Jul 17, 2024
@imobachgs imobachgs deleted the drop-issues-context branch July 17, 2024 09:20
teclator added a commit that referenced this pull request Jul 23, 2024
Adapted the UI using TanStack query instead of route loaders and
useEffect hooks.


---

Related to #1439,
#1452,
#1470, and
#1483
dgdavid added a commit that referenced this pull request Jul 23, 2024
Similar to #1439, #1452, and #1470, this set of changes aims to replace
the client/software with Tanstack queries.

Note that was not possible to fully drop the software client. It has to
wait until migration of
[`WithStatus`](https://github.com/openSUSE/agama/blob/bd2f35d0ead6d74931189f5619579f6c3ffa2770/web/src/client/mixins.js#L83)
and
[`WithProgress`](https://github.com/openSUSE/agama/blob/bd2f35d0ead6d74931189f5619579f6c3ffa2770/web/src/client/mixins.js#L147)
mixins too.
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants