Skip to content

feat(web): partially adapt storage UI to queries#1577

Merged
imobachgs merged 12 commits intostorage-typescriptfrom
storage-queries
Sep 5, 2024
Merged

feat(web): partially adapt storage UI to queries#1577
imobachgs merged 12 commits intostorage-typescriptfrom
storage-queries

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs commented Sep 5, 2024 •
edited
Loading

Trello: https://trello.com/c/nV7mjrf9/

This is the first step towards adapting the storage code to use queries. As this part of the code is rather complex, we decided to move as many components as possible to TypeScript to have a kind of security net.

What is included

  • Add a set of types from from our OpenAPI docs (see fix(rust): revamp the OpenAPI specification #1564) in api/storage/types.
  • Add a set of storage UI types in types/storage. We should unify the types, but let's do it later.
  • Define a new api/storage module moving big chunks of the StorageClient code.
  • Define a set of queries under queries/storage.
  • Adapt the ProposalPage component to use queries. It retrieves a lot of information that injects to nested components.
  • Convert ProposalPage and InstallationDeviceField to TypeScript.

What is missing

  • As you may see, the front end is not building. That problems (and other subtle bugs) will be fixed as we adapt the rest of storage components to TypeScript. So a bunch of additional pull requests will follow.
  • Additionally, we are removing all those skeletons from the UI. We will use a unified mechanism.

@imobachgs imobachgs changed the title Storage queries feat(web): partially adapt storage UI to queries Sep 5, 2024
dgdavid
dgdavid approved these changes Sep 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I guess this is just one of many incoming changes against the storage-typescript feature branch, please go ahead. It's looking good and, honestly, I prefer to make a more in depth review when the code is closer to a final state. Hope you don't mind.

@imobachgs imobachgs merged commit 83621ad into storage-typescript Sep 5, 2024
@imobachgs imobachgs deleted the storage-queries branch September 5, 2024 07:56
@imobachgs imobachgs mentioned this pull request Sep 5, 2024
Merged
imobachgs added a commit that referenced this pull request Sep 5, 2024
@imobachgs
refactor(web): convert some storage components to TypeScript (round 1) (
b6ec8e0 
#1578)

Continuation of #1577. It covers the conversion of the following
components/modules:

* `EncryptionField`
* `PartitionsField`
* `ProposalSettingsSection`
* `SnapshotsField`
* `VolumeDialog`
* `InvalidMaxSizeError`
* `VolumeFields`
* `VolumeLocationDialog`
* `VolumeLocationSelectorTable`
* `BootSelection`
* `utils`
@imobachgs imobachgs mentioned this pull request Sep 5, 2024
Merged
imobachgs added a commit that referenced this pull request Sep 5, 2024
@imobachgs
feat(web): use queries in boot and space policy selectors (#1580)
488de5f 
Follow-up of #1577. It adapts `BootSelection` and `SpacePolicySelection`
to use queries.
This was referenced Sep 5, 2024
Merged
Merged
imobachgs added a commit that referenced this pull request Sep 6, 2024
@imobachgs
refactor(web): convert some storage components to TypeScript (round …
0689f5d 
…2) (#1583)

Continuation of #1577. It covers the conversion of the following
components/modules:

* `BootConfigField`
* `device-utils`
* `SpaceActionsTable`
* `DeviceSelectorTable`
* `EncryptionSettingsDialog`
* `ProposalActionDialog`
* `ProposalActionSummary`
* `StoragePage`
* `ProposalResultSection`
* `ProposalTransactionalInfo`
* `SpaceActionsTable`
imobachgs added a commit that referenced this pull request Sep 6, 2024
@imobachgs
refactor(web): use queries and TypeScript in storage components (#1585)
4373ec5 
Merge the following pull requests into `master`:

* #1577 
* #1578 
* #1580
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
Merged
imobachgs added a commit that referenced this pull request Sep 20, 2024
@imobachgs
Update to release 10 (#1622)
574a1a5 
Prepare for releasing Agama 10·

* #1263
* #1330
* #1407
* #1408
* #1410
* #1411
* #1412
* #1416
* #1417
* #1419
* #1420
* #1421
* #1422
* #1423
* #1424
* #1425
* #1428
* #1429
* #1430
* #1431
* #1432
* #1433
* #1436
* #1437
* #1438
* #1439
* #1440
* #1441
* #1443
* #1444
* #1445
* #1449
* #1450
* #1451
* #1452
* #1453
* #1454
* #1455
* #1456
* #1457
* #1459
* #1460
* #1462
* #1464
* #1465
* #1466
* #1467
* #1468
* #1469
* #1470
* #1471
* #1472
* #1473
* #1475
* #1476
* #1477
* #1478
* #1479
* #1480
* #1481
* #1482
* #1483
* #1484
* #1485
* #1486
* #1487
* #1488
* #1489
* #1491
* #1492
* #1493
* #1494
* #1496
* #1497
* #1498
* #1499
* #1500
* #1501
* #1502
* #1503
* #1504
* #1505
* #1506
* #1507
* #1508
* #1510
* #1511
* #1512
* #1513
* #1514
* #1515
* #1516
* #1517
* #1518
* #1519
* #1520
* #1522
* #1523
* #1524
* #1525
* #1526
* #1527
* #1528
* #1529
* #1530
* #1531
* #1532
* #1533
* #1534
* #1535
* #1536
* #1537
* #1540
* #1541
* #1543
* #1544
* #1545
* #1546
* #1547
* #1548
* #1549
* #1550
* #1552
* #1553
* #1554
* #1555
* #1556
* #1557
* #1558
* #1559
* #1560
* #1562
* #1563
* #1565
* #1566
* #1567
* #1568
* #1569
* #1570
* #1571
* #1572
* #1573
* #1574
* #1575
* #1576
* #1577
* #1578
* #1579
* #1580
* #1581
* #1583
* #1584
* #1585
* #1586
* #1587
* #1588
* #1589
* #1590
* #1591
* #1592
* #1593
* #1596
* #1597
* #1598
* #1600
* #1602
* #1605
* #1606
* #1607
* #1608
* #1610
* #1611
* #1612
* #1613
* #1614
* #1619
* #1620
* #1621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgdavid dgdavid dgdavid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@imobachgs @dgdavid