feat(web): adapt to HTTP API of DASD operations by jreidinger · Pull Request #1549 · agama-project/agama

jreidinger · 2024-08-21T14:12:54Z

Trello: https://trello.com/c/2LC8JEZR/3743-8-agama-adapt-dasd-configuration-to-current-architecture

This PR is the following step to support for DASD devices on s390x architectures. It includes:

adaptation of web API to changes done in feat(rust): add an HTTP/JSON API to DASD operations #1532

coveralls · 2024-08-21T14:25:53Z

coverage: 71.801% (-0.002%) from 71.803%
when pulling e896085 on web-dasd
into a6926d6 on master.

web/src/routes/storage.tsx

web/src/types/dasd.ts

web/src/components/storage/DASDFormatProgress.tsx

web/src/components/storage/DASDTable.tsx

web/src/queries/dasd.ts

imobachgs

Please, check the new mutations.

web/src/components/storage/DASDTable.tsx

dgdavid

It looks good to me, but pease check the log entry.

Great job 👍 👍 👍 BTW

web/src/queries/dasd.ts

web/package/agama-web-ui.changes

dgdavid · 2024-09-05T09:31:21Z

web/src/routes/storage.tsx

+      element: <DASDPage />,
+      handle: { name: N_("DASD") },
+      loader: async () => {
+        if (!DASDSupported()) return redirect(PATHS.root);


Not sure if worth mentioning that loader will not be executed until loading the route. Probably not.

Also, we should add a mechanism to avoid the application crashing because trying to go to the route before login but in another round of routes improvements, not now 😉

BTW, thanks a lot for taking the time of doing manual testing of this part and catching such a bug.

I can improve the message or add a note in the ZFCP PR just for not delay this one.

Prepare for releasing Agama 10· * #1263 * #1330 * #1407 * #1408 * #1410 * #1411 * #1412 * #1416 * #1417 * #1419 * #1420 * #1421 * #1422 * #1423 * #1424 * #1425 * #1428 * #1429 * #1430 * #1431 * #1432 * #1433 * #1436 * #1437 * #1438 * #1439 * #1440 * #1441 * #1443 * #1444 * #1445 * #1449 * #1450 * #1451 * #1452 * #1453 * #1454 * #1455 * #1456 * #1457 * #1459 * #1460 * #1462 * #1464 * #1465 * #1466 * #1467 * #1468 * #1469 * #1470 * #1471 * #1472 * #1473 * #1475 * #1476 * #1477 * #1478 * #1479 * #1480 * #1481 * #1482 * #1483 * #1484 * #1485 * #1486 * #1487 * #1488 * #1489 * #1491 * #1492 * #1493 * #1494 * #1496 * #1497 * #1498 * #1499 * #1500 * #1501 * #1502 * #1503 * #1504 * #1505 * #1506 * #1507 * #1508 * #1510 * #1511 * #1512 * #1513 * #1514 * #1515 * #1516 * #1517 * #1518 * #1519 * #1520 * #1522 * #1523 * #1524 * #1525 * #1526 * #1527 * #1528 * #1529 * #1530 * #1531 * #1532 * #1533 * #1534 * #1535 * #1536 * #1537 * #1540 * #1541 * #1543 * #1544 * #1545 * #1546 * #1547 * #1548 * #1549 * #1550 * #1552 * #1553 * #1554 * #1555 * #1556 * #1557 * #1558 * #1559 * #1560 * #1562 * #1563 * #1565 * #1566 * #1567 * #1568 * #1569 * #1570 * #1571 * #1572 * #1573 * #1574 * #1575 * #1576 * #1577 * #1578 * #1579 * #1580 * #1581 * #1583 * #1584 * #1585 * #1586 * #1587 * #1588 * #1589 * #1590 * #1591 * #1592 * #1593 * #1596 * #1597 * #1598 * #1600 * #1602 * #1605 * #1606 * #1607 * #1608 * #1610 * #1611 * #1612 * #1613 * #1614 * #1619 * #1620 * #1621

jreidinger force-pushed the web-dasd branch from 145c975 to 9e8cc77 Compare August 21, 2024 15:02

start with new web API for DASD

9e8cc77

jreidinger changed the base branch from master to http-dasd August 22, 2024 08:41

teclator and others added 4 commits August 22, 2024 10:15

[WIP] Try to add a supported check to DASD API

daf6124

try to have working dasd#supported

e05a7cc

Replaced DASD is supported check

5e246d1

[WIP] Start adapting DASDPage

c772472

jreidinger commented Aug 22, 2024

View reviewed changes

web/src/routes/storage.tsx Show resolved Hide resolved

teclator and others added 16 commits August 22, 2024 12:28

Temporal fix for showing dasds

7e4b34d

adapt ids

d866bd8

Merge branch 'http-dasd' into web-dasd

8788502

Start moving DASD pages to Typescript

08edd00

add dasd probe

e796206

add more api and queries for dasd

2b40f73

add format api call

455fa66

fix sort types

fa7ac90

add backspace icon

b2d7f6c

Move DASD actions to queries

6251f72

add jobs api

6e8e581

Merge remote-tracking branch 'origin/http-dasd' into web-dasd

d4be0c8

Moved DASD filters to queries

fc3497f

Move DASD selection to queries

41251bf

Merge remote-tracking branch 'origin/http-dasd' into web-dasd

b7ab21c

first attempt to implement proper format with storage jobs

897bbf4

teclator reviewed Aug 26, 2024

View reviewed changes

web/src/types/dasd.ts Outdated Show resolved Hide resolved

jreidinger and others added 4 commits August 27, 2024 10:37

optimize dasd devices query to not use invalidate

fc8f79c

Merge branch 'http-dasd' into web-dasd

f7530fd

Fix jobs url

87e4e13

Getting rid of the DASD initial state

fa3eae7

dgdavid reviewed Sep 3, 2024

View reviewed changes

web/src/components/storage/DASDFormatProgress.tsx Show resolved Hide resolved

dgdavid reviewed Sep 3, 2024

View reviewed changes

web/src/components/storage/DASDTable.tsx Outdated Show resolved Hide resolved

Use mutations instead of API direct calls

918a5e3

teclator force-pushed the web-dasd branch from 4fcb8d1 to 918a5e3 Compare September 3, 2024 16:10

More changes based on code review

4405715

jreidinger commented Sep 4, 2024

View reviewed changes

web/src/queries/dasd.ts Outdated Show resolved Hide resolved

teclator added 3 commits September 4, 2024 09:43

Replace dasd filter queries by component state

6d140be

Replace dasd selection queries by component state

8fc01b9

Do not set any info about formatting.

50e76ad

imobachgs requested changes Sep 4, 2024

View reviewed changes

web/src/components/storage/DASDTable.tsx Outdated Show resolved Hide resolved

web/src/components/storage/DASDTable.tsx Show resolved Hide resolved

teclator added 7 commits September 4, 2024 12:03

Added DASD route only if supported

a75354f

Removed selected DASD leftover queries

669f102

Use only one mutation for modifying DASD state

76d295b

Do not modify existent cache but return new object

a705ac6

Another inmutability fix

d0bf495

Merge branch 'master' into web-dasd

3c9c319

Added changelog

1c9dfdd

teclator requested review from dgdavid and imobachgs September 4, 2024 21:02

dgdavid reviewed Sep 4, 2024

View reviewed changes

web/src/queries/dasd.ts Outdated Show resolved Hide resolved

web/package/agama-web-ui.changes Show resolved Hide resolved

imobachgs approved these changes Sep 4, 2024

View reviewed changes

Apply suggestions from CR

9b96a93

teclator requested a review from dgdavid September 5, 2024 06:20

dgdavid approved these changes Sep 5, 2024

View reviewed changes

Redirect to storage page in case DASD is not supported

e896085

dgdavid reviewed Sep 5, 2024

View reviewed changes

teclator merged commit f38e15b into master Sep 5, 2024

teclator deleted the web-dasd branch September 5, 2024 09:38

imobachgs mentioned this pull request Sep 20, 2024

Update to release 10 #1622

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(web): adapt to HTTP API of DASD operations#1549

feat(web): adapt to HTTP API of DASD operations#1549
teclator merged 62 commits intomasterfrom
web-dasd

jreidinger commented Aug 21, 2024 •

edited by imobachgs

Loading

Uh oh!

coveralls commented Aug 21, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imobachgs left a comment

Uh oh!

Uh oh!

Uh oh!

dgdavid left a comment

Uh oh!

Uh oh!

Uh oh!

dgdavid Sep 5, 2024

Uh oh!

teclator Sep 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

jreidinger commented Aug 21, 2024 • edited by imobachgs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Aug 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imobachgs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dgdavid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dgdavid Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

teclator Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jreidinger commented Aug 21, 2024 •

edited by imobachgs

Loading

coveralls commented Aug 21, 2024 •

edited

Loading