Skip to content

fix(rust): do not use camel case in event names#1559

Merged
imobachgs merged 3 commits intomasterfrom
fix-events-names
Aug 28, 2024
Merged

fix(rust): do not use camel case in event names#1559
imobachgs merged 3 commits intomasterfrom
fix-events-names

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once renamed the JobId to jobId :P

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 28, 2024

Coverage Status

coverage: 71.68%. remained the same
when pulling dc89478 on fix-events-names
into d1a0e5a on master.

@teclator
Copy link
Copy Markdown
Contributor

LGTM

@imobachgs imobachgs merged commit 4cabf6c into master Aug 28, 2024
@imobachgs imobachgs deleted the fix-events-names branch August 28, 2024 12:54
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants