Merge from azure-master#4
Merged
TinaHu1 merged 64 commits intoTinaHu1:masterfrom Aug 22, 2019
Merged
Conversation
* Create AzureMachineLearning.json Initial version of data plane swagger. * Fix typos and semantic issues identified by checks Removed duplicate operation ids fixed typos * Remove extraneous comma Removed extraneous comma. * Address code review comments. * Removing x-ms-example attribute to pass model validation. The Model Validation Job is failing for this PR and I am not sure why. Attempting to remove the examples to see if that resolves the issue. * Create readme.md Added readme.md * Add suppression for some errors/warnings * Apply suggestions from code review fix misspellings Co-Authored-By: hendrytl <36863669+hendrytl@users.noreply.github.com> * Removed suppressions until approved * undo path casing changes; fix typos. * Adding Approved suppressions * Update AzureMachineLearning.json Incorporate feedback from API Review Board: make pagination consistent with nextlink rename contracts to be more user friendly (remove DTO, etc.) Fix file upload object type Remove Stream and other C# datatypes * Fix duplicate Id and add examples Update example files to be references instead of inline. Fixed duplicate Id. * Update model management rename some classes, add more documentation. * Split swagger into component pieces Separate the api into multiple components to facilitate easier review and management. * Add suppression for camelCase Added approved suppression for camelCase issue in hyperdrive. * Add more examples for hyperdrive fix tab to spaces. remove required from runhistory host. * Update example for hyperdrive Was missing response details. * updaing Artifacts swagger to add the xml comments for contracts * Update artifact.json * removing extra spaces * spelling fix * Addressing comments from Azure review board * spelling corrections * Round 3 Azure API Review comments addressed * Adding custom words of AzureML Swaggers * Hyperdrive structure correction * Example File Corrections * Change snake_case to camelCase and resolve comment * Artifact, datastore, Runhistory, execution services updated * updating swaggers * updating swaggers * Update MMS Swagger Json Patch * updating execution swagger * making version 2019-08-01 * Update readme.md * Update cancelRunWithUri.json * Delete cancelRun.json * Update startRun.json * Update startLocalRun.json * Update startSnapshotRun.json * Update cancelHyperDriveExperiment.json * Update createHyperDriveExperiment.json * Update startLocalRun.json * Update startLocalRun.json * Update startLocalRun.json * Update startLocalRun.json * Update startLocalRun.json * Update startLocalRun.json * Update startLocalRun.json * Update startLocalRun.json * Update startLocalRun.json * minor fix * Add new custom words for AzureML DataPlane Rest APIs * Update custom-words.txt * disabling enum settings and mms updates * Added HyperDrive prefix to policy definitions, removed unused definitions and made study_id optional. * Add custom words from HyperDrive json
* Add swagger specification for firewall policy resource (#6708) * Add swagger specification for firewall policy resource * Add the firewall policy spec to the list of files in readme.md * Add priority to the Filter Rule in example for Rule Group Get * Encapsulate the response body in a body property * Suppress errors due to missing properties inhertied from base resource: * Fix typo * Fix Build errors * Address review comments * Revert capitalization of Tags and OperationId as Semantic valiation expects lower case * Drop 201 response from examples * Capitalize first letter of the operationId and tags values * Add swagger changes for azure firewall in vHub * Add a ref to the example file for Azure Firewall in vHub * Fix validation check * Address review comments * Fix typos in Network's examples (#6740) * Add missing read-only property "loadBalancerFrontendIpConfiguration" to publicIpPrefix (#6693) * Make patch operations async for VNGs and VNG Connections (#6695) * fix: network 2019-06-01 model validation errror (#6790) Thumbprint -> thumbprint * Update definition of ApplicationGatewayOnDemandProbe (#6716) * Fix definition of ApplicationGatewayOnDemandProbe * minor changes * Copy fixed examples to 2019-02-01
…olation (#6947) * added support sample interpolation in swagger * Fixed the model validation failure
* fix schema property naming * remove redundent schema reference
- Remove empty body for RESPONSE_SCHEMA_NOT_IN_SPEC errors - Wrapped headers for FileGetPropertiesFromNode.json - leavingpool -> leavingPool - targetDedicated -> targetDedicatedNodes - currentDedicated -> currentDedicatedNodes
- Index is integer rather than a string - Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE error - start is an integer rather than a string - count is an integer rather than a string - Add missing 200 responses
* Adding swagger spec for unprepare subnet * fixing display name for unprepare example * Update custom-words.txt
* Swagger: Allowing for VMSS reference during VM creation * fixing typo
* Add alertRuleTemplates endpoint to securityInsight * update indentation * fix merge conflict * Bookmarks swagger updates * fix typos * fix typo * run validation again. network problem
Remove null body and headers for RESPONSE_SCHEMA_NOT_IN_SPEC errors
#6852) * Add managedInstaceAdministrators.json to readme file, which reprepresents AutoRest configuration file for Sql * Add missing json to package-composite-v2, package-composite-v1, package-pure-2017-03-preview and package-2017-03-preview
…/js SDK generation (#6971)
* Mark ownerEmail as required properties for workspace RP * fix examples
Remove hard tabs
* Fixing errors in swagger examples of Azure Backup * Updating reference path for moved file * Removing trailing commas in examples
…tings and AzureBlobFSWriteSettings (#6954) * add property blockSizeInMB for blobsink and blobFSsink * fix property type * Move property from BlobSink (datasetV1) to AzureBlobStorageWriteSettings (datasetV2) * Enable override for StoreWriteSettings * remove redundant property
* Add validation transfer API for Microsoft.Billing. * Fix syntax. * Fix spelling Co-Authored-By: Nick Schonning <nschonni@gmail.com> * Fix Semantic. * Remove unused definition. * Fix example. * Convert the validate api response to a list. * Restructure the example. * Address review comments.
* Fixing errors in swagger examples of Azure Backup * Updating reference path for moved file * Removing trailing commas in examples * Fixing semantic errors in Azure backup example
* adding_version_2019_05_15 * fix_error_in_examples_case_issue * fix_version_in_examples * enother_try_to_fix_examples * another_try * handle_error_201_in_examples * fix_readmego * another_try_fix_readme_files * try_fix_readme * fix_readme_and_resolve_comment * add_ofers_change * add_suppression * add_dor_and_ofer_changes * try_understand_one_error * try_the_other_string * try_add_suppressions * try_another_suppressions_syntax * try_suppressions * try_zim_suggestion * trying_to_fix_example_kusto_data_connection_validation * trying_to_fix_example_kusto_databases_check_name_availability * try2 * try3 * delete_suppressions * try4
* commit with 2018-09-30 files * incremental snapshots going in disk.json * adding incremental examples * upload size bytes and incremental snapshots * adding diskSizeBytes to disk.json * adding descriptions to the disk create option enums * adding diskSizeBytes as a read only field * adding encryptionSettingsVersion * updating readme * add example * removing extra descriptions * Revert "removing extra descriptions" This reverts commit 3a0f6498ff6d12663a4929cc78d05911112124c7. * adding enum descriptions back in * adding descriptions for some enums * fixing incorrect use of name and replacing it with the correct property value * adding unique id * fixing the snapshots examples so that model validation passes - don't send a read only field in the request * fixing typo * removing diskSizeBytes from snapshot\disk update properties and adding a unique id for disk properties * pr comments
…#7013) * New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Initialize the swagger spec review for azure data. * fix validation issues. * fixed Linter check. * fix by comments. * fix by comments * fix by comments. * fix CI error. * fix by comments. * fix build issue. * update the resource definition * update examples. * fix swagger * fix examples issue. * Swagger review comments * Moving azure-sdk on line up
…Added priority, eviction policy and billing profile to VirtualMachineProperties. Also, adding optional billing profile to VMSS Create and Update APIs. (#6961)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.