Add swagger specification for firewall policy resource by gimotwanMSFT · Pull Request #6708 · Azure/azure-rest-api-specs

gimotwanMSFT · 2019-07-23T20:18:17Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-07-23T20:20:27Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmptdgc0rub/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmptdgc0rub/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4387/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4387)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .

<--- Last few GCs --->

[24628:0x41a6cc0]    89152 ms: Mark-sweep 1375.9 (1425.4) -> 1375.5 (1425.4) MB, 1220.5 / 0.0 ms  (average mu = 0.136, current mu = 0.017) allocation failure scavenge might not succeed
[24628:0x41a6cc0]    90762 ms: Mark-sweep 1376.4 (1425.4) -> 1376.0 (1425.9) MB, 1606.9 / 0.0 ms  (average mu = 0.063, current mu = 0.002) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x381c3321e6e9 <JSObject>
    0: builtin exit frame: stringify(this=0x381c33211a21 <Object map = 0x32603c7842a9>,0x30a41d3026f1 <undefined>,0x30a41d3026f1 <undefined>,0x11cdadacf6b9 <JSArray[9]>,0x381c33211a21 <Object map = 0x32603c7842a9>)

    1: arguments adaptor frame: 1->3
    2: IdentitySourceMapping [0x7896a308b69] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4387/node_modules/@microsoft.azure/autorest-core...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea03c8 v8::internal::Factory::AllocateRawWithAllocationSite(v8::internal::Handle<v8::internal::Map>, v8::internal::PretenureFlag, v8::internal::Handle<v8::internal::AllocationSite>) [node]
11: 0xead4c5 v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, v8::internal::PretenureFlag) [node]
12: 0xead9b4 v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, int, int, v8::internal::ArrayStorageAllocationMode, v8::internal::PretenureFlag) [node]
13: 0xf994a8 v8::internal::JsonStringifier::JsonStringifier(v8::internal::Isolate*) [node]
14: 0xba90ec v8::internal::Builtin_JsonStringify(int, v8::internal::Object**, v8::internal::Isolate*) [node]
15: 0x15033b3dbf7d

azuresdkci · 2019-07-23T20:44:01Z

Can one of the admins verify this patch?

AutorestCI · 2019-07-23T20:50:28Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 600, in urlopen
    chunked=chunked)
  File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 384, in _make_request
    six.raise_from(e, None)
  File "<string>", line 2, in raise_from
  File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 380, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/lib/python3.6/http/client.py", line 1331, in getresponse
    response.begin()
  File "/usr/lib/python3.6/http/client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python3.6/http/client.py", line 266, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/requests/adapters.py", line 449, in send
    timeout=timeout
  File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 638, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "/usr/local/lib/python3.6/dist-packages/urllib3/util/retry.py", line 368, in increment
    raise six.reraise(type(error), error, _stacktrace)
  File "/usr/local/lib/python3.6/dist-packages/urllib3/packages/six.py", line 685, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 600, in urlopen
    chunked=chunked)
  File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 384, in _make_request
    six.raise_from(e, None)
  File "<string>", line 2, in raise_from
  File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 380, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/lib/python3.6/http/client.py", line 1331, in getresponse
    response.begin()
  File "/usr/lib/python3.6/http/client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python3.6/http/client.py", line 266, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
urllib3.exceptions.ProtocolError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 257, in generate_sdk_from_git_object
    readme_files_infered = get_readme_files_from_git_object(git_object, restapi_git_folder)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkCore.py", line 146, in get_readme_files_from_git_object
    files_list = [file.filename for file in get_files(git_object)]
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkCore.py", line 146, in <listcomp>
    files_list = [file.filename for file in get_files(git_object)]
  File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 64, in __iter__
    newElements = self._grow()
  File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 76, in _grow
    newElements = self._fetchNextPage()
  File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 201, in _fetchNextPage
    headers=self.__headers
  File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 275, in requestJsonAndCheck
    return self.__check(*self.requestJson(verb, url, parameters, headers, input, self.__customConnection(url)))
  File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 335, in requestJson
    return self.__requestEncode(cnx, verb, url, parameters, headers, input, encode)
  File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 388, in __requestEncode
    status, responseHeaders, output = self.__requestRaw(cnx, verb, url, requestHeaders, encoded_input)
  File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 412, in __requestRaw
    response = cnx.getresponse()
  File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 114, in getresponse
    r = verb(url, headers=self.headers, data=self.input, timeout=self.timeout, verify=self.verify, allow_redirects=False)
  File "/usr/local/lib/python3.6/dist-packages/requests/sessions.py", line 546, in get
    return self.request('GET', url, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/requests/sessions.py", line 533, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/requests/sessions.py", line 646, in send
    r = adapter.send(request, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/requests/adapters.py", line 498, in send
    raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',))

nschonni

Reques -> Request

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/firewallPolicy.json

anton-evseev

Please also trim trailing spaces and empty lines (preferably with JSON formatter)

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/firewallPolicy.json

…xpects lower case

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/azureFirewall.json

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/firewallPolicy.json

gimotwanMSFT · 2019-07-25T21:57:43Z

Can someone share how long would it take to get a Signed SDK once this PR is merged?

gimotwanMSFT · 2019-07-26T16:37:13Z

All comments have been addressed. Appreciate if the PR can now be merged

gimotwanMSFT · 2019-07-26T23:45:08Z

The PR to merge these changes to the private repo is here: https://github.com/Azure/azure-rest-api-specs-pr/pull/801

The ARM RP Review team has already approved this swagger change.

majastrz · 2019-07-29T19:31:51Z

@sergey-shandar, why did you merge it when the WaitingForARMFeedback label was present on the pull request?

majastrz · 2019-07-29T19:32:38Z

Luckily the changes look good from ARM side, so I'll update the labels to match.

sergey-shandar · 2019-07-29T20:49:13Z

@majastrz because it was already reviewed by ARM in another private PR.

* Add swagger specification for firewall policy resource (#6708) * Add swagger specification for firewall policy resource * Add the firewall policy spec to the list of files in readme.md * Add priority to the Filter Rule in example for Rule Group Get * Encapsulate the response body in a body property * Suppress errors due to missing properties inhertied from base resource: * Fix typo * Fix Build errors * Address review comments * Revert capitalization of Tags and OperationId as Semantic valiation expects lower case * Drop 201 response from examples * Capitalize first letter of the operationId and tags values * Add swagger changes for azure firewall in vHub * Add a ref to the example file for Azure Firewall in vHub * Fix validation check * Address review comments * Fix typos in Network's examples (#6740) * Add missing read-only property "loadBalancerFrontendIpConfiguration" to publicIpPrefix (#6693) * Make patch operations async for VNGs and VNG Connections (#6695) * fix: network 2019-06-01 model validation errror (#6790) Thumbprint -> thumbprint * Update definition of ApplicationGatewayOnDemandProbe (#6716) * Fix definition of ApplicationGatewayOnDemandProbe * minor changes * Copy fixed examples to 2019-02-01

Add swagger specification for firewall policy resource

c8c3678

gimotwanMSFT requested a review from MikhailTryakhov as a code owner July 23, 2019 20:18

gimotwanMSFT added 2 commits July 23, 2019 13:20

Add the firewall policy spec to the list of files in readme.md

a08e114

Add priority to the Filter Rule in example for Rule Group Get

1c7ce5a

gimotwanMSFT added 2 commits July 23, 2019 13:51

Encapsulate the response body in a body property

f588424

Suppress errors due to missing properties inhertied from base resource:

0035cd1

nschonni reviewed Jul 23, 2019

View reviewed changes

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/firewallPolicy.json Outdated Show resolved Hide resolved

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/firewallPolicy.json Outdated Show resolved Hide resolved

gimotwanMSFT added 2 commits July 23, 2019 14:46

Fix typo

68b815f

Fix Build errors

f9fe275

sergey-shandar added the Reassign label Jul 24, 2019

anton-evseev reviewed Jul 24, 2019

View reviewed changes

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/firewallPolicy.json Outdated Show resolved Hide resolved

anton-evseev suggested changes Jul 24, 2019

View reviewed changes

gimotwanMSFT added 7 commits July 24, 2019 10:17

Address review comments

da3a2b9

Revert capitalization of Tags and OperationId as Semantic valiation e…

1d18f84

…xpects lower case

Drop 201 response from examples

8055a83

Capitalize first letter of the operationId and tags values

75a1988

Add swagger changes for azure firewall in vHub

4641bc7

Add a ref to the example file for Azure Firewall in vHub

2b34e15

Fix validation check

4cbb81f

anton-evseev reviewed Jul 25, 2019

View reviewed changes

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/azureFirewall.json Show resolved Hide resolved

anton-evseev suggested changes Jul 25, 2019

View reviewed changes

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/firewallPolicy.json Outdated Show resolved Hide resolved

Address review comments

d93b4f2

anton-evseev approved these changes Jul 26, 2019

View reviewed changes

sergey-shandar self-assigned this Jul 26, 2019

sergey-shandar removed the Reassign label Jul 26, 2019

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 26, 2019

sergey-shandar approved these changes Jul 27, 2019

View reviewed changes

sergey-shandar merged commit 3f9699a into Azure:network-july-release Jul 27, 2019

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 29, 2019

This was referenced Sep 16, 2019

Add support for Firewall Policy Azure/azure-cli#10543

Closed

Add support for VirtualHub in Azure Firewall Azure/azure-cli#10544

Closed

Conversation

gimotwanMSFT commented Jul 23, 2019 • edited by praveensri Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Jul 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Jul 23, 2019

Uh oh!

AutorestCI commented Jul 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

nschonni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anton-evseev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gimotwanMSFT commented Jul 25, 2019

Uh oh!

gimotwanMSFT commented Jul 26, 2019

Uh oh!

gimotwanMSFT commented Jul 26, 2019

Uh oh!

majastrz commented Jul 29, 2019

Uh oh!

majastrz commented Jul 29, 2019

Uh oh!

sergey-shandar commented Jul 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gimotwanMSFT commented Jul 23, 2019 •

edited by praveensri

Loading

AutorestCI commented Jul 23, 2019 •

edited

Loading

AutorestCI commented Jul 23, 2019 •

edited

Loading