Skip to content

Fix typos in Network's examples#6740

Merged
yungezz merged 1 commit intoAzure:network-july-releasefrom
anton-evseev:example-typos
Aug 1, 2019
Merged

Fix typos in Network's examples#6740
yungezz merged 1 commit intoAzure:network-july-releasefrom
anton-evseev:example-typos

Conversation

@anton-evseev
Copy link
Contributor

@anton-evseev anton-evseev commented Jul 26, 2019

Microsofot -> Microsoft in Network's examples

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 26, 2019

SDK Automation [Logs] (Generated from df68c58, Iteration 1)

Warning Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Warning Java: Azure/azure-sdk-for-java [Logs] [Diff]
  • Warning network/resource-manager/v2017_10_01 [Logs]
  • Warning network/resource-manager/v2018_04_01 [Logs]
  • Warning network/resource-manager/v2018_06_01 [Logs]
  • Warning network/resource-manager/v2018_07_01 [Logs]
  • Warning network/resource-manager/v2018_08_01 [Logs]
  • Warning network/resource-manager/v2018_12_01 [Logs]
  • Warning network/resource-manager/v2019_02_01 [Logs]
  • Warning network/resource-manager/v2019_04_01 [Logs]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning network/mgmt/2015-06-15 [Logs]
  • Warning network/mgmt/2016-03-30 [Logs]
  • Warning network/mgmt/2016-06-01 [Logs]
  • Warning network/mgmt/2016-09-01 [Logs]
  • Warning network/mgmt/2016-12-01 [Logs]
  • Warning network/mgmt/2017-03-01 [Logs]
  • Warning network/mgmt/2017-06-01 [Logs]
  • Warning network/mgmt/2017-08-01 [Logs]
  • Warning network/mgmt/2017-09-01 [Logs]
  • Warning network/mgmt/2017-10-01 [Logs]
  • Warning network/mgmt/2017-11-01 [Logs]
  • Warning network/mgmt/2018-01-01 [Logs]
  • Warning network/mgmt/2018-02-01 [Logs]
  • Warning network/mgmt/2018-04-01 [Logs]
  • Warning network/mgmt/2018-06-01 [Logs]
  • Warning network/mgmt/2018-07-01 [Logs]
  • Warning network/mgmt/2018-08-01 [Logs]
  • Warning network/mgmt/2018-10-01 [Logs]
  • Warning network/mgmt/2018-11-01 [Logs]
  • Warning network/mgmt/2018-12-01 [Logs]
  • Warning network/mgmt/2019-02-01 [Logs]
  • Warning network/mgmt/2019-04-01 [Logs]
  • Warning preview/network/mgmt/2015-05-01-preview [Logs]
Succeeded JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
Succeeded Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jul 26, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 26, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@anton-evseev
Copy link
Contributor Author

If this is too much files changed at once, I can split this PR into 3 by years (2017, 2018, 2019)

@daviwil
Copy link
Contributor

daviwil commented Jul 26, 2019

@OpenAPIBot sdkautomation rebuild

1 similar comment
@ghost
Copy link

ghost commented Jul 26, 2019

@OpenAPIBot sdkautomation rebuild

@anton-evseev
Copy link
Contributor Author

Azure bot stopped assigning reviewers, so I'm not sure whom I should ping
@sergey-shandar @zikalino could you please take a look?

@anton-evseev anton-evseev force-pushed the example-typos branch 2 times, most recently from df68c58 to 5da051f Compare July 30, 2019 13:27
@anton-evseev
Copy link
Contributor Author

@lirenhe could you please take a look?

@raych1 raych1 added the Reassign label Aug 1, 2019
@yungezz yungezz merged commit 343d133 into Azure:network-july-release Aug 1, 2019
@anton-evseev anton-evseev deleted the example-typos branch August 5, 2019 18:17
sergey-shandar pushed a commit that referenced this pull request Aug 14, 2019
* Add swagger specification for firewall policy resource (#6708)

* Add swagger specification for firewall policy resource

* Add the firewall policy spec to the list of files in readme.md

* Add priority to the Filter Rule in example for Rule Group Get

* Encapsulate the response body in a body property

* Suppress errors due to missing properties inhertied from base resource:

* Fix typo

* Fix Build errors

* Address review comments

* Revert capitalization of Tags and OperationId as Semantic valiation expects lower case

* Drop 201 response from examples

* Capitalize first letter of the operationId and tags values

* Add swagger changes for azure firewall in vHub

* Add a ref to the example file for Azure Firewall in vHub

* Fix validation check

* Address review comments

* Fix typos in Network's examples (#6740)

* Add missing read-only property "loadBalancerFrontendIpConfiguration" to publicIpPrefix (#6693)

* Make patch operations async for VNGs and VNG Connections (#6695)

* fix: network 2019-06-01 model validation errror (#6790)

Thumbprint -> thumbprint

* Update definition of ApplicationGatewayOnDemandProbe (#6716)

* Fix definition of ApplicationGatewayOnDemandProbe

* minor changes

* Copy fixed examples to 2019-02-01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants