Adding swagger spec for unprepare subnet#6904
Conversation
Automation for azure-sdk-for-pythonEncountered a Subprocess error: (azure-sdk-for-python)
Command: ['/usr/local/bin/autorest', '/tmp/tmpe5fg45aq/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpe5fg45aq/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview'] AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4390/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4390)
Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .
<--- Last few GCs --->
[3834:0x254ecc0] 67889 ms: Mark-sweep 1379.5 (1426.6) -> 1379.3 (1427.1) MB, 1445.6 / 0.0 ms (average mu = 0.105, current mu = 0.003) allocation failure GC in old space requested
[3834:0x254ecc0] 69320 ms: Mark-sweep 1379.8 (1427.1) -> 1379.7 (1427.6) MB, 1428.4 / 0.0 ms (average mu = 0.055, current mu = 0.002) allocation failure GC in old space requested
<--- JS stacktrace --->
==== JS stack trace =========================================
0: ExitFrame [pc: 0x19bf283dbe1d]
Security context: 0x018da469e6e9 <JSObject>
1: storeMappingPair(aka storeMappingPair) [0x3ec8b7e56621] [/node_modules/yaml-ast-parser/dist/src/loader.js:~270] [pc=0x19bf28e5f3da](this=0x079d3ba026f1 <undefined>,state=0x2070ce602201 <State map = 0x20f86f66a799>,_result=0x20aaebf05891 <Object map = 0x1a9e648ecec9>,keyTag=0x079d3ba022b1 <null>,keyNode=0x02153f7ffba9 <Object map = 0x1a9e648ed811>,valu...
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
1: 0x8dc510 node::Abort() [node]
2: 0x8dc55c [node]
3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
5: 0xec7bf2 [node]
6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x19bf283dbe1d |
|
Can one of the admins verify this patch? |
|
Spellchecker is failing because it doesn't recognize the word "unprepare" and it's variants. My suggestion is to add them to |
anton-evseev
left a comment
There was a problem hiding this comment.
Looks good aside for a couple nitpicks for consistency's sake
|
@MikhailTryakhov and @Am018 can you review this |
|
@Azure/arm-api-review-board could you please review this PR? |
|
@ryansbenson could you please review this PR? |
9c1f252 to
7c78ea2
Compare
In Testing, Please Ignore[Logs] (Generated from 7c78ea2, Iteration 1)
|
|
Retargeted to |
|
Signing off from ARM side. One small comment - can the service name be an enum? if not, may be update the description to provide a few examples. |
Automation for azure-sdk-for-goA PR has been created for you: |
* swagger changes for PrometheusHaCluster provider * resolved comments * updated file names * renamed referenced files, added clustername to custom-wrods.txt * fix for swagger prettier check * renamed provider type to HACluster * making provider type consistent with V1
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.