Skip to content

Add validation transfer API for Microsoft.Billing. #6940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tjprescott merged 9 commits into from
Aug 20, 2019
Merged

Add validation transfer API for Microsoft.Billing. #6940

tjprescott merged 9 commits into from
Aug 20, 2019

Conversation

@jbnpaul
Copy link
Contributor

@jbnpaul jbnpaul commented Aug 13, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@jbnpaul jbnpaul requested a review from wilcobmsft as a code owner August 13, 2019 04:21
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 09d9848, Iteration 9)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Warning billing/resource-manager/v2017_02_27_preview [Logs]
  • Warning billing/resource-manager/v2017_04_24_preview [Logs]
  • Warning billing/resource-manager/v2018_03_01_preview [Logs]
  • Warning billing/resource-manager/v2018_11_01_preview [Logs]
  • Failed billing/resource-manager/v2019_10_01_preview [Logs]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@AutorestCI
Copy link

AutorestCI commented Aug 13, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#6866

@AutorestCI
Copy link

AutorestCI commented Aug 13, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

azuresdkci commented Aug 13, 2019

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from tjprescott August 13, 2019 05:06
@tjprescott tjprescott added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 13, 2019
jbnpaul and others added 2 commits August 13, 2019 10:31
@jbnpaul @nschonni
Fix spelling
5777a58 
Co-Authored-By: Nick Schonning <[email protected]>
@jobinMS
Fix Semantic.
540fc1b
@AutorestCI AutorestCI mentioned this pull request Aug 13, 2019
Closed
This was referenced Aug 13, 2019
Merged
Merged
Merged
Merged
Closed
Merged
@ryansbenson ryansbenson removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 14, 2019
@ryansbenson ryansbenson added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 14, 2019
@PhoenixHe-NV PhoenixHe-NV mentioned this pull request Aug 16, 2019
Closed
@tjprescott
Copy link
Member

tjprescott commented Aug 19, 2019

/azurepipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 19, 2019

Azure Pipelines successfully started running 2 pipeline(s).

@tjprescott tjprescott merged commit ea01158 into Azure:master Aug 20, 2019
@AutorestCI AutorestCI mentioned this pull request Aug 20, 2019
Merged
leniatgh pushed a commit to leniatgh/azure-rest-api-specs that referenced this pull request May 13, 2022
@JackTn
merge new PULL_REQUEST_TEMPLATE for RPSaaSMaster (Azure#6940)
185de7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjprescott tjprescott tjprescott approved these changes

@ryansbenson ryansbenson ryansbenson approved these changes

@wilcobmsft wilcobmsft Awaiting requested review from wilcobmsft wilcobmsft is a code owner

+1 more reviewer

@nschonni nschonni nschonni left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tjprescott tjprescott

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jbnpaul @AutorestCI @azuresdkci @tjprescott @nschonni @ryansbenson @jobinMS