Skip to content

Update definition of ApplicationGatewayOnDemandProbe#6716

Merged
sergey-shandar merged 3 commits intoAzure:network-july-releasefrom
patoda:network-july-release
Aug 12, 2019
Merged

Update definition of ApplicationGatewayOnDemandProbe#6716
sergey-shandar merged 3 commits intoAzure:network-july-releasefrom
patoda:network-july-release

Conversation

@patoda
Copy link

@patoda patoda commented Jul 24, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@patoda patoda requested a review from MikhailTryakhov as a code owner July 24, 2019 08:15
@AutorestCI
Copy link

AutorestCI commented Jul 24, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmp5w83xl7l/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp5w83xl7l/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4390/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4390)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .

<--- Last few GCs --->

[28815:0x2f24cc0]    91502 ms: Mark-sweep 1377.5 (1425.5) -> 1377.1 (1426.0) MB, 1664.8 / 0.0 ms  (average mu = 0.100, current mu = 0.002) allocation failure scavenge might not succeed
[28815:0x2f24cc0]    92961 ms: Mark-sweep 1377.9 (1426.0) -> 1377.6 (1426.5) MB, 1455.7 / 0.0 ms  (average mu = 0.054, current mu = 0.002) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x1397aef9e6e9 <JSObject>
    0: builtin exit frame: stringify(this=0x1397aef91a21 <Object map = 0x27f5027042a9>,0x3cb1cb8826f1 <undefined>,0x3cb1cb8826f1 <undefined>,0x3bf247bcf029 <JSArray[5]>,0x1397aef91a21 <Object map = 0x27f5027042a9>)

    1: arguments adaptor frame: 1->3
    2: IdentitySourceMapping [0x14388445e761] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4390/node_modules/@microsoft.azure/autorest-cor...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea0466 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [node]
11: 0xea0cea v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [node]
12: 0xead814 v8::internal::Factory::NewJSArrayStorage(v8::internal::Handle<v8::internal::JSArray>, int, int, v8::internal::ArrayStorageAllocationMode) [node]
13: 0xead9cc v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, int, int, v8::internal::ArrayStorageAllocationMode, v8::internal::PretenureFlag) [node]
14: 0xf994a8 v8::internal::JsonStringifier::JsonStringifier(v8::internal::Isolate*) [node]
15: 0xba90ec v8::internal::Builtin_JsonStringify(int, v8::internal::Object**, v8::internal::Isolate*) [node]
16: 0x1c2095edbf7d

@patoda patoda requested a review from bwanner July 24, 2019 08:20
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5497

@anton-evseev
Copy link
Contributor

@lirenhe could you please take a look?

@raych1 raych1 added the Reassign label Aug 1, 2019
@yungezz yungezz assigned mmyyrroonn and lirenhe and unassigned mmyyrroonn Aug 1, 2019
@yungezz yungezz added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed Reassign labels Aug 1, 2019
@anton-evseev
Copy link
Contributor

@Azure/arm-api-review-board could you please review this PR?

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 12, 2019
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@anton-evseev
Copy link
Contributor

@lirenhe could you please merge this PR?

@sergey-shandar sergey-shandar merged commit fff5022 into Azure:network-july-release Aug 12, 2019
sergey-shandar pushed a commit that referenced this pull request Aug 14, 2019
* Add swagger specification for firewall policy resource (#6708)

* Add swagger specification for firewall policy resource

* Add the firewall policy spec to the list of files in readme.md

* Add priority to the Filter Rule in example for Rule Group Get

* Encapsulate the response body in a body property

* Suppress errors due to missing properties inhertied from base resource:

* Fix typo

* Fix Build errors

* Address review comments

* Revert capitalization of Tags and OperationId as Semantic valiation expects lower case

* Drop 201 response from examples

* Capitalize first letter of the operationId and tags values

* Add swagger changes for azure firewall in vHub

* Add a ref to the example file for Azure Firewall in vHub

* Fix validation check

* Address review comments

* Fix typos in Network's examples (#6740)

* Add missing read-only property "loadBalancerFrontendIpConfiguration" to publicIpPrefix (#6693)

* Make patch operations async for VNGs and VNG Connections (#6695)

* fix: network 2019-06-01 model validation errror (#6790)

Thumbprint -> thumbprint

* Update definition of ApplicationGatewayOnDemandProbe (#6716)

* Fix definition of ApplicationGatewayOnDemandProbe

* minor changes

* Copy fixed examples to 2019-02-01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants