Skip to content

Add missing read-only property "loadBalancerFrontendIpConfiguration" to publicIpPrefix#6693

Merged
zikalino merged 1 commit intoAzure:network-july-releasefrom
anton-evseev:pip-add-lb
Aug 1, 2019
Merged

Add missing read-only property "loadBalancerFrontendIpConfiguration" to publicIpPrefix#6693
zikalino merged 1 commit intoAzure:network-july-releasefrom
anton-evseev:pip-add-lb

Conversation

@anton-evseev
Copy link
Contributor

Fixes #6506

  • Add missing read-only property "loadBalancerFrontendIpConfiguration" to publicIpPrefix
  • Fix examples for publicIpPrefix

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2019

SDK Automation [Logs] (Generated from 6489f65, Iteration 1)

Failed Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • Failed sdk/network/azure-mgmt-network [Logs]
In-Progress Java: Azure/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: Azure/azure-sdk-for-go [Logs]
  • Package generation in progress.
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
  • Failed @azure/arm-network [Logs]
Failed Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jul 22, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmp853b8u25/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp853b8u25/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4390/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4390)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .

<--- Last few GCs --->

[21370:0x2829cc0]    86607 ms: Scavenge 1378.4 (1423.4) -> 1378.0 (1423.9) MB, 14.6 / 0.0 ms  (average mu = 0.189, current mu = 0.064) allocation failure
[21370:0x2829cc0]    86626 ms: Scavenge 1378.9 (1423.9) -> 1378.5 (1424.9) MB, 7.9 / 0.0 ms  (average mu = 0.189, current mu = 0.064) allocation failure
[21370:0x2829cc0]    87818 ms: Mark-sweep 1379.3 (1424.9) -> 1379.0 (1424.9) MB, 1189.2 / 0.0 ms  (average mu = 0.116, current mu = 0.032) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x14fae661e6e9 <JSObject>
    0: builtin exit frame: stringify(this=0x14fae6611a21 <Object map = 0x25a85c842a9>,0x1959ded826f1 <undefined>,0x1959ded826f1 <undefined>,0x3c5b74e4c611 <JSArray[6]>,0x14fae6611a21 <Object map = 0x25a85c842a9>)

    1: arguments adaptor frame: 1->3
    2: IdentitySourceMapping [0x31ee61d0e51] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4390/node_modules/@microsoft.azure/autorest-core/d...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xe9f655  [node]
11: 0xea6eca v8::internal::Factory::NewRawOneByteString(int, v8::internal::PretenureFlag) [node]
12: 0x11d69d0 v8::internal::IncrementalStringBuilder::IncrementalStringBuilder(v8::internal::Isolate*) [node]
13: 0xf99459 v8::internal::JsonStringifier::JsonStringifier(v8::internal::Isolate*) [node]
14: 0xba90ec v8::internal::Builtin_JsonStringify(int, v8::internal::Object**, v8::internal::Isolate*) [node]
15: 0x48d165dbf7d

@AutorestCI
Copy link

AutorestCI commented Jul 22, 2019

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpey_iclrn/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpey_iclrn/sdk', '--java', '--multiapi', '--use=@microsoft.azure/autorest.java@2.1.85', '--verbose']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4383/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4383)
   Including configuration file 'file:///tmp/tmpey_iclrn/rest/specification/network/resource-manager/readme.java.md'
   Loading AutoRest extension '@microsoft.azure/autorest.java' (2.1.85->2.1.85)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-04"} .
   Including configuration file 'file:///tmp/tmpey_iclrn/rest/specification/network/resource-manager/readme.java.md'

<--- Last few GCs --->

[11638:0x28f2bb0]    78373 ms: Scavenge 1380.2 (1424.3) -> 1380.0 (1424.8) MB, 16.0 / 0.0 ms  (average mu = 0.133, current mu = 0.023) allocation failure
[11638:0x28f2bb0]    79717 ms: Mark-sweep 1380.7 (1424.8) -> 1380.5 (1425.3) MB, 1339.9 / 0.0 ms  (average mu = 0.082, current mu = 0.025) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x35ae58c1e6e9 <JSObject>
    0: builtin exit frame: stringify(this=0x35ae58c11a21 <Object map = 0x2c77a24042a9>,0x394ba36826f1 <undefined>,0x394ba36826f1 <undefined>,0x2b58749e0119 <JSArray[24]>,0x35ae58c11a21 <Object map = 0x2c77a24042a9>)

    1: arguments adaptor frame: 1->3
    2: IdentitySourceMapping [0xd582e8c9d01] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4383/node_modules/@microsoft.azure/autorest-cor...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xe9f655  [node]
11: 0xea6eca v8::internal::Factory::NewRawOneByteString(int, v8::internal::PretenureFlag) [node]
12: 0x11d6b25 v8::internal::IncrementalStringBuilder::Extend() [node]
13: 0xf9b303 v8::internal::JsonStringifier::SerializeString(v8::internal::Handle<v8::internal::String>) [node]
14: 0xf9f7cf v8::internal::JsonStringifier::Result v8::internal::JsonStringifier::Serialize_<false>(v8::internal::Handle<v8::internal::Object>, bool, v8::internal::Handle<v8::internal::Object>) [node]
15: 0xfa0626 v8::internal::JsonStringifier::Result v8::internal::JsonStringifier::Serialize_<false>(v8::internal::Handle<v8::internal::Object>, bool, v8::internal::Handle<v8::internal::Object>) [node]
16: 0xfa1719 v8::internal::JsonStringifier::Stringify(v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>) [node]
17: 0xba9121 v8::internal::Builtin_JsonStringify(int, v8::internal::Object**, v8::internal::Isolate*) [node]
18: 0x187ef5edbf7d

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Jul 22, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@anton-evseev
Copy link
Contributor Author

SDK java failed due to 2hr timeout, I guess because I've updated a lot of API versions it tried to re-generate each of them and that took too long
@zikalino could you please review this PR?

@anton-evseev anton-evseev changed the base branch from master to network-july-release July 26, 2019 08:00
@zikalino
Copy link

@number213 I will try to build Python locally

@anton-evseev
Copy link
Contributor Author

All checks have passed, could you please merge this PR, @zikalino?

@zikalino
Copy link

zikalino commented Aug 1, 2019

Everything looks fine.
Also checked example related to this change and it looks good.

The changes in examples made it look really large, while the actual change in the API is pretty small.
I think it's better to place large example changes in a separate PR.

@zikalino zikalino merged commit 748e335 into Azure:network-july-release Aug 1, 2019
@anton-evseev anton-evseev deleted the pip-add-lb branch August 5, 2019 18:08
sergey-shandar pushed a commit that referenced this pull request Aug 14, 2019
* Add swagger specification for firewall policy resource (#6708)

* Add swagger specification for firewall policy resource

* Add the firewall policy spec to the list of files in readme.md

* Add priority to the Filter Rule in example for Rule Group Get

* Encapsulate the response body in a body property

* Suppress errors due to missing properties inhertied from base resource:

* Fix typo

* Fix Build errors

* Address review comments

* Revert capitalization of Tags and OperationId as Semantic valiation expects lower case

* Drop 201 response from examples

* Capitalize first letter of the operationId and tags values

* Add swagger changes for azure firewall in vHub

* Add a ref to the example file for Azure Firewall in vHub

* Fix validation check

* Address review comments

* Fix typos in Network's examples (#6740)

* Add missing read-only property "loadBalancerFrontendIpConfiguration" to publicIpPrefix (#6693)

* Make patch operations async for VNGs and VNG Connections (#6695)

* fix: network 2019-06-01 model validation errror (#6790)

Thumbprint -> thumbprint

* Update definition of ApplicationGatewayOnDemandProbe (#6716)

* Fix definition of ApplicationGatewayOnDemandProbe

* minor changes

* Copy fixed examples to 2019-02-01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants