Skip to content

fix: azsadmin model validation errors#6953

Merged
ArcturusZhang merged 1 commit intoAzure:masterfrom
nschonni:fix--azsadmin-model-validation-errors
Aug 14, 2019
Merged

fix: azsadmin model validation errors#6953
ArcturusZhang merged 1 commit intoAzure:masterfrom
nschonni:fix--azsadmin-model-validation-errors

Conversation

@nschonni
Copy link
Copy Markdown
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

- Index is integer rather than a string
- Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE error
- start is an integer rather than a string
- count is an integer rather than a string
- Add missing 200 responses
@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Aug 14, 2019

In Testing, Please Ignore

[Logs] (Generated from bdf9d1a, Iteration 1)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 14, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 14, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@ArcturusZhang
Copy link
Copy Markdown
Member

The checks have all passed. Three of them show in progress status due to a bug in github or azure devops.

@ArcturusZhang ArcturusZhang merged commit 5bd6555 into Azure:master Aug 14, 2019
@nschonni nschonni deleted the fix--azsadmin-model-validation-errors branch August 14, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants