Skip to content

Enable API swagger#6905

Merged
Juliehzl merged 4 commits intoAzure:masterfrom
nitegupt:enableSwagger/nitegupt
Aug 14, 2019
Merged

Enable API swagger#6905
Juliehzl merged 4 commits intoAzure:masterfrom
nitegupt:enableSwagger/nitegupt

Conversation

@nitegupt
Copy link
Copy Markdown
Contributor

@nitegupt nitegupt commented Aug 8, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI AutorestCI mentioned this pull request Aug 8, 2019
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 8, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5748

@azuresdkci azuresdkci requested a review from Juliehzl August 8, 2019 18:59
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 8, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: dep ensure
Finished with return code 1
and output:

grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export google.golang.org/api: failed to fetch source for https://code.googlesource.com/google-api-go-client: unable to get repository: Cloning into '/tmp/tmp75kz2131/pkg/dep/sources/https---code.googlesource.com-google--api--go--client'...
POST git-upload-pack (791 bytes)
remote: Sending approximately 158.57 MiB ...
remote: Counting objects: 1
remote: Counting objects: 1434, done
remote: Finding sources:   1% (15/1434)
remote: Finding sources:   2% (29/1434)
remote: Finding sources:   3% (44/1434)
remote: Finding sources:   4% (58/1434)
remote: Finding sources:   5% (72/1434)
remote: Finding sources:   6% (87/1434)
remote: Finding sources:   7% (101/1434)
remote: Finding sources:   8% (115/1434)
remote: Finding sources:   9% (130/1434)
remote: Finding sources:  10% (144/1434)
remote: Finding sources:  11% (158/1434)
remote: Finding sources:  12% (173/1434)
remote: Finding sources:  13% (187/1434)
remote: Finding sources:  14% (201/1434)
remote: Finding sources:  15% (216/1434)
remote: Finding sources:  16% (230/1434)
remote: Finding sources:  17% (244/1434)
remote: Finding sources:  18% (259/1434)
remote: Finding sources:  19% (273/1434)
remote: Finding sources:  20% (287/1434)
remote: Finding sources:  21% (302/1434)
remote: Finding sources:  22% (316/1434)
remote: Finding sources:  23% (330/1434)
remote: Finding sources:  24% (345/1434)
remote: Finding sources:  25% (359/1434)
remote: Finding sources:  26% (373/1434)
remote: Finding sources:  27% (388/1434)
remote: Finding sources:  28% (402/1434)
remote: Finding sources:  29% (416/1434)
remote: Finding sources:  30% (431/1434)
remote: Finding sources:  31% (445/1434)
remote: Finding sources:  32% (459/1434)
remote: Finding sources:  33% (474/1434)
remote: Finding sources:  34% (488/1434)
remote: Finding sources:  35% (502/1434)
remote: Finding sources:  36% (517/1434)
remote: Finding sources:  37% (531/1434)
remote: Finding sources:  38% (545/1434)
remote: Finding sources:  39% (560/1434)
remote: Finding sources:  40% (574/1434)
remote: Finding sources:  41% (588/1434)
remote: Finding sources:  42% (603/1434)
remote: Finding sources:  43% (617/1434)
remote: Finding sources:  44% (631/1434)
remote: Finding sources:  45% (646/1434)
remote: Finding sources:  46% (660/1434)
remote: Finding sources:  47% (674/1434)
remote: Finding sources:  48% (689/1434)
remote: Finding sources:  49% (703/1434)
remote: Finding sources:  50% (717/1434)
remote: Finding sources:  51% (732/1434)
remote: Finding sources:  52% (746/1434)
remote: Finding sources:  53% (761/1434)
remote: Finding sources:  54% (775/1434)
remote: Finding sources:  55% (789/1434)
remote: Finding sources:  56% (804/1434)
remote: Finding sources:  57% (818/1434)
remote: Finding sources:  58% (832/1434)
remote: Finding sources:  59% (847/1434)
remote: Finding sources:  60% (861/1434)
remote: Finding sources:  61% (875/1434)
remote: Finding sources:  62% (890/1434)
remote: Finding sources:  63% (904/1434)
remote: Finding sources:  64% (918/1434)
remote: Finding sources:  65% (933/1434)
remote: Finding sources:  66% (947/1434)
remote: Finding sources:  67% (961/1434)
remote: Finding sources:  68% (976/1434)
remote: Finding sources:  69% (990/1434)
remote: Finding sources:  70% (1004/1434)
remote: Finding sources:  71% (1019/1434)
remote: Finding sources:  72% (1033/1434)
remote: Finding sources:  73% (1047/1434)
remote: Finding sources:  74% (1062/1434)
remote: Finding sources:  75% (1076/1434)
remote: Finding sources:  76% (1090/1434)
remote: Finding sources:  77% (1105/1434)
remote: Finding sources:  78% (1119/1434)
remote: Finding sources:  79% (1133/1434)
remote: Finding sources:  80% (1148/1434)
remote: Finding sources:  81% (1162/1434)
remote: Finding sources:  82% (1176/1434)
remote: Finding sources:  83% (1191/1434)
remote: Finding sources:  84% (1205/1434)
remote: Finding sources:  85% (1219/1434)
remote: Finding sources:  86% (1234/1434)
remote: Finding sources:  87% (1248/1434)
remote: Finding sources:  88% (1262/1434)
remote: Finding sources:  89% (1277/1434)
remote: Finding sources:  90% (1291/1434)
remote: Finding sources:  91% (1305/1434)
remote: Finding sources:  92% (1320/1434)
remote: Finding sources:  93% (1334/1434)
remote: Finding sources:  94% (1348/1434)
remote: Finding sources:  95% (1363/1434)
remote: Finding sources:  96% (1377/1434)
remote: Finding sources:  97% (1391/1434)
remote: Finding sources:  98% (1406/1434)
remote: Finding sources:  99% (1420/1434)
remote: Finding sources: 100% (1434/1434)
remote: Finding sources: 100% (1434/1434)
Receiving objects:   0% (1/79773)
Receiving objects:   1% (798/79773)
Receiving objects:   1% (889/79773), 451.87 KiB | 401.00 KiB/s
Receiving objects:   1% (898/79773), 643.81 KiB | 123.00 KiB/s
Receiving objects:   1% (905/79773), 707.79 KiB | 78.00 KiB/s
Receiving objects:   1% (929/79773), 963.70 KiB | 94.00 KiB/s
Receiving objects:   1% (931/79773), 1.00 MiB | 93.00 KiB/s
Receiving objects:   1% (998/79773), 1.75 MiB | 148.00 KiB/s
Receiving objects:   1% (1048/79773), 2.75 MiB | 217.00 KiB/s
Receiving objects:   1% (1331/79773), 5.56 MiB | 326.00 KiB/s
Receiving objects:   1% (1344/79773), 5.63 MiB | 400.00 KiB/s
Receiving objects:   1% (1373/79773), 6.06 MiB | 522.00 KiB/s
Receiving objects:   1% (1389/79773), 6.38 MiB | 544.00 KiB/s
Receiving objects:   2% (1596/79773), 6.38 MiB | 544.00 KiB/s
Receiving objects:   3% (2394/79773), 7.06 MiB | 624.00 KiB/s
Receiving objects:   4% (3191/79773), 7.06 MiB | 624.00 KiB/s
Receiving objects:   5% (3989/79773), 7.06 MiB | 624.00 KiB/s
Receiving objects:   5% (4044/79773), 7.06 MiB | 624.00 KiB/s
Receiving objects:   6% (4787/79773), 7.06 MiB | 624.00 KiB/s
Receiving objects:   7% (5585/79773), 7.06 MiB | 624.00 KiB/s
Receiving objects:   8% (6382/79773), 7.06 MiB | 624.00 KiB/s
Receiving objects:   9% (7180/79773), 7.06 MiB | 624.00 KiB/s
Receiving objects:  10% (7978/79773), 7.06 MiB | 624.00 KiB/s
Receiving objects:  11% (8776/79773), 7.75 MiB | 669.00 KiB/s
Receiving objects:  12% (9573/79773), 7.75 MiB | 669.00 KiB/s
Receiving objects:  13% (10371/79773), 7.75 MiB | 669.00 KiB/s
Receiving objects:  14% (11169/79773), 7.75 MiB | 669.00 KiB/s
Receiving objects:  15% (11966/79773), 7.75 MiB | 669.00 KiB/s
Receiving objects:  16% (12764/79773), 7.75 MiB | 669.00 KiB/s
Receiving objects:  16% (13002/79773), 8.25 MiB | 656.00 KiB/s
Receiving objects:  17% (13562/79773), 8.25 MiB | 656.00 KiB/s
Receiving objects:  17% (13709/79773), 8.31 MiB | 511.00 KiB/s
Receiving objects:  18% (14360/79773), 8.31 MiB | 511.00 KiB/s
Receiving objects:  19% (15157/79773), 8.31 MiB | 511.00 KiB/s
Receiving objects:  19% (15915/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  20% (15955/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  21% (16753/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  22% (17551/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  23% (18348/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  24% (19146/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  25% (19944/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  26% (20741/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  27% (21539/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  28% (22337/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  29% (23135/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  30% (23932/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  31% (24730/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  32% (25528/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  33% (26326/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  34% (27123/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  35% (27921/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  36% (28719/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  37% (29517/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  38% (30314/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  39% (31112/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  40% (31910/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  41% (32707/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  42% (33505/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  43% (34303/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  44% (35101/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  45% (35898/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  46% (36696/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  47% (37494/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  48% (38292/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  49% (39089/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  49% (39765/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  50% (39887/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  51% (40685/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  52% (41482/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  53% (42280/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  54% (43078/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  55% (43876/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  56% (44673/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  57% (45471/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  58% (46269/79773), 8.44 MiB | 302.00 KiB/s
Receiving objects:  58% (46829/79773), 11.44 MiB | 547.00 KiB/s
Receiving objects:  58% (46966/79773), 13.37 MiB | 707.00 KiB/s
Receiving objects:  59% (47067/79773), 13.37 MiB | 707.00 KiB/s
Receiving objects:  59% (47213/79773), 14.50 MiB | 792.00 KiB/s
Receiving objects:  59% (47589/79773), 17.19 MiB | 912.00 KiB/s
Receiving objects:  59% (47593/79773), 17.62 MiB | 942.00 KiB/s
Receiving objects:  59% (47703/79773), 17.94 MiB | 1.19 MiB/s
Receiving objects:  60% (47864/79773), 18.81 MiB | 1.00 MiB/s
Receiving objects:  60% (48148/79773), 19.81 MiB | 862.00 KiB/s
Receiving objects:  60% (48221/79773), 19.94 MiB | 848.00 KiB/s
Receiving objects:  60% (48311/79773), 20.25 MiB | 420.00 KiB/s
Receiving objects:  60% (48589/79773), 21.62 MiB | 461.00 KiB/s
Receiving objects:  60% (48619/79773), 21.62 MiB | 461.00 KiB/s
Receiving objects:  61% (48662/79773), 21.81 MiB | 493.00 KiB/s
Receiving objects:  61% (48669/79773), 21.93 MiB | 418.00 KiB/s
Receiving objects:  61% (48796/79773), 22.37 MiB | 370.00 KiB/s
Receiving objects:  61% (48816/79773), 22.50 MiB | 307.00 KiB/s
Receiving objects:  61% (48845/79773), 22.56 MiB | 295.00 KiB/s
Receiving objects:  61% (48878/79773), 22.62 MiB | 277.00 KiB/s
Receiving objects:  61% (49343/79773), 24.37 MiB | 355.00 KiB/s
Receiving objects:  61% (49400/79773), 24.56 MiB | 343.00 KiB/s
Receiving objects:  62% (49460/79773), 24.56 MiB | 343.00 KiB/s
Receiving objects:  62% (49469/79773), 25.08 MiB | 415.00 KiB/s
Receiving objects:  62% (49516/79773), 25.25 MiB | 403.00 KiB/s
Receiving objects:  62% (49626/79773), 25.25 MiB | 403.00 KiB/s
Receiving objects:  62% (49845/79773), 26.25 MiB | 517.00 KiB/s
Receiving objects:  63% (50257/79773), 26.25 MiB | 517.00 KiB/s
Receiving objects:  63% (50295/79773), 28.24 MiB | 798.00 KiB/s
Receiving objects:  63% (50312/79773), 29.06 MiB | 618.00 KiB/s
Receiving objects:  63% (50362/79773), 29.43 MiB | 607.00 KiB/s
Receiving objects:  63% (50536/79773), 29.93 MiB | 689.00 KiB/s
Receiving objects:  63% (50592/79773), 30.68 MiB | 738.00 KiB/s
Receiving objects:  63% (50600/79773), 30.81 MiB | 378.00 KiB/s
Receiving objects:  63% (50605/79773), 30.81 MiB | 378.00 KiB/s
Receiving objects:  63% (50698/79773), 31.49 MiB | 353.00 KiB/s
Receiving objects:  63% (50932/79773), 32.49 MiB | 434.00 KiB/s
Receiving objects:  64% (51055/79773), 32.49 MiB | 434.00 KiB/s
Receiving objects:  64% (51379/79773), 33.81 MiB | 598.00 KiB/s
Receiving objects:  64% (51440/79773), 34.43 MiB | 425.00 KiB/s
Receiving objects:  64% (51545/79773), 34.99 MiB | 436.00 KiB/s
Receiving objects:  64% (51613/79773), 35.56 MiB | 457.00 KiB/s
error: RPC failed; curl 56 GnuTLS recv error (-110): The TLS connection was non-properly terminated.
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed
: command failed: [git clone --recursive -v --progress https://code.googlesource.com/google-api-go-client /tmp/tmp75kz2131/pkg/dep/sources/https---code.googlesource.com-google--api--go--client]: exit status 128

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Aug 8, 2019

Can one of the admins verify this patch?

@Juliehzl Juliehzl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 9, 2019
@nitegupt nitegupt changed the title [DO NOT MERGE] Enable API swagger Enable API swagger Aug 12, 2019
@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Aug 12, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 5d19a5a, Iteration 1)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning preview/subscription/mgmt/2017-11-01-preview [Logs]
  • Warning preview/subscription/mgmt/2018-03-01-preview [Logs]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Succeeded JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@openapi-sdkautomation openapi-sdkautomation Bot mentioned this pull request Aug 12, 2019
Merged
ryansbenson
ryansbenson approved these changes Aug 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 12, 2019
Juliehzl
Juliehzl reviewed Aug 13, 2019
View reviewed changes
Comment thread ...iption/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/subscriptions.json
},
"/subscriptions/{subscriptionId}/providers/Microsoft.Subscription/enable": {
"post": {
"operationId": "Subscriptions_Enable",
Copy link
Copy Markdown
Contributor

@Juliehzl Juliehzl Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to use camelCase when naming operationId

Copy link
Copy Markdown
Contributor Author

@nitegupt nitegupt Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current naming convention is used in all of our other APIs.

@Juliehzl Juliehzl merged commit ad6d5f6 into Azure:master Aug 14, 2019
leniatgh pushed a commit to leniatgh/azure-rest-api-specs that referenced this pull request May 13, 2022
@aronip
Adding security profile to virtual machine model for setting efi sett…
457e29a 
…ings. (Azure#6905)

* adding security profile for efi settings.

* fixes

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryansbenson ryansbenson ryansbenson approved these changes

@Juliehzl Juliehzl Juliehzl approved these changes

Assignees

@Juliehzl Juliehzl

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nitegupt @AutorestCI @azuresdkci @ryansbenson @Juliehzl