Adding non mandatory fields in ProtectedItem and AzureVmWorkloadProte…#6818
Merged
yungezz merged 6 commits intoAzure:masterfrom Aug 15, 2019
SanjayHukumRana:master
Merged
Adding non mandatory fields in ProtectedItem and AzureVmWorkloadProte…#6818yungezz merged 6 commits intoAzure:masterfrom SanjayHukumRana:master
yungezz merged 6 commits intoAzure:masterfrom
SanjayHukumRana:master
Conversation
…ctionPolicy Adding additional fields for ProtectedItem related to soft delete feature ; description of each field is in the fields. In AzureVmWorkloadProtectionPolicy adding another field for fixup of policy
In Testing, Please Ignore[Logs] (Generated from d0e6593, Iteration 6)
|
|
|
Contributor
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Since these fields are added in base class ProtectedItem , removing them from MabFileFolderProtectedItem
Rehydrated is not in dictionary of swagger valiation and thus removed from description
lirenhe
added
the
WaitForARMFeedback
ravbhatnagar
reviewed
Aug 7, 2019
Contributor
ravbhatnagar
left a comment
ravbhatnagar
left a comment
There was a problem hiding this comment.
@SanjayHukumRana - few comments.
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-12-01/bms.json
Show resolved
Hide resolved
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2017-07-01/bms.json
Outdated
Show resolved
Hide resolved
Updating the new field for deleted time in ProtectedItem while keeping the syncTime for MABfileFolderProtectedItem
Removed the change to AzureVmWorkloadProtectionPolicy as this requires new api version
ravbhatnagar
added
ARMSignedOff
Contributor
|
Signing off from ARM side. |
This was referenced Aug 13, 2019
lirenhe
approved these changes
Aug 13, 2019
Camelcasing of isDeferredDeleteScheduleUpcoming field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ctionPolicy
Adding additional fields for ProtectedItem related to soft delete feature ; description of each field is in the fields.
In AzureVmWorkloadProtectionPolicy adding another field for fixup of policy
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.