Skip to content

Comments

Adding version 2019_05_15#6690

Merged
zikalino merged 27 commits intoAzure:masterfrom
shdavido:master
Aug 21, 2019
Merged

Adding version 2019_05_15#6690
zikalino merged 27 commits intoAzure:masterfrom
shdavido:master

Conversation

@shdavido
Copy link
Contributor

@shdavido shdavido commented Jul 21, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 88cdfad, Iteration 25)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed kusto/resource-manager/v2018_09_07_preview [Logs]
  • Failed kusto/resource-manager/v2019_01_21 [Logs]
  • Failed kusto/resource-manager/v2019_05_15 [Logs]

@AutorestCI AutorestCI mentioned this pull request Jul 21, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jul 21, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6829

@AutorestCI
Copy link

AutorestCI commented Jul 21, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 21, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

azuresdkci commented Jul 21, 2019

Can one of the admins verify this patch?

This was referenced Jul 31, 2019
Closed
Closed
@sergey-shandar
Copy link
Contributor

sergey-shandar commented Jul 31, 2019

@shdavido are you still working on this PR?

@shdavido
Copy link
Contributor Author

shdavido commented Aug 1, 2019 via email

@shdavido
Copy link
Contributor Author

shdavido commented Aug 1, 2019

Hi,

Yes, sorry for the amount of commits it’s the first time I’m changing this project.

I have the remaining errors in the automatic checks:

  1. (ModelValidation)Additional properties not allowed:
    DataConnections_dataConnectionValidation

  2. (ModelValidation)expected type object but found type string:
    DataConnections_CheckNameAvailability

  3. (lintdif) Properties of a PATCH request body must not be required. PATCH operation: 'DataConnections_Update' Model Definition: 'DataConnection' Property: 'kind'
    otential new ARM errors
    ========================
    R2016 - PatchBodyParametersSchema
    Properties of a PATCH request body must not be required. PATCH operation: 'DataConnections_Update' Model Definition: 'DataConnection' Property: 'kind'
    at specification/azure-kusto/resource-manager/Microsoft.Kusto/stable/2019-05-15/kusto.json:2047

  4. (lintdif)Warnings:
    Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableDiskEncryption
    Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled

As for:

  1. Changing this will cause us to do a breaking change and a lot of work (it’s exist in earlier versions)
  2. I don’t sure what exactly it points to, but I think it can only cause a breaking change and a lot of work (it’s exist in earlier versions).
  3. AFAIK @ravit Dennis told me the same as 1,2 about that.
  4. We already have implanatiation in our backend that is in use, that using those as Booleans, so changing those also can make a lot of work.

I’ll ask for approval although having the listed errors and warnings above, if you have any objections please tell me.

Thanks,
Shahar

@zikalino zikalino self-assigned this Aug 5, 2019
@zikalino
Copy link

zikalino commented Aug 5, 2019

@shdavido for lintdiff etc, could you add suppressions in the readme file? otherwise I won't be able to merge.

@zikalino
Copy link

zikalino commented Aug 5, 2019

@sergey-shandar I have reassigned this one to myself. I hope you're ok with that :-)

@AutorestCI AutorestCI mentioned this pull request Aug 18, 2019
Merged
This was referenced Aug 18, 2019
Merged
Merged
Merged
@zikalino zikalino merged commit 9d4d2f2 into Azure:master Aug 21, 2019
@shdavido shdavido mentioned this pull request Sep 12, 2019
Merged
leniatgh pushed a commit to leniatgh/azure-rest-api-specs that referenced this pull request May 13, 2022
@valakhin
New private preview version changes for SCOM RP (Azure#6690)
dc0cbbb 
* New private preview version changes for SCOM RP

* Fix pretier and api doc version

* Made latest version as default version

* Changes to leverage User Managed Identity for SCOM MI instance

* Fixed  format errors

* Removed unwanted delegation props from SCOM MI payload

* Added identity property to PATCH operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergey-shandar sergey-shandar Awaiting requested review from sergey-shandar

2 more reviewers

@nschonni nschonni nschonni left review comments

@zikalino zikalino zikalino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zikalino zikalino

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shdavido @AutorestCI @azuresdkci @sergey-shandar @zikalino @nschonni