Create AzureMachineLearning.json data-plane API.

[hendrytl]

Initial version of data plane swagger.
This API is pending review by the API Review Board.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and have all been fixed in this PR.
• The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

• Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
• adding/removing APIs.
• adding/removing properties.
• adding/removing API-version.
• adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

• If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
  Please follow the link to find more details on API review process.

[AutorestCI]

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[AutorestCI]

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

[azuresdkci]

Can one of the admins verify this patch?

[nschonni]

I'm guessing the suggestions will only make sense looking at the files tab. GitHub has a hard time with large files and Suggestions

[AutorestCI]

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

[AutorestCI]

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

[hendrytl]

@nschonni @veronicagg The model validation check is failing with
"fatal error: xmsExampleFunc is not a function, {}
##[error]Bash exited with code '1'."
Any ideas what the issue is or how to troubleshoot?
Update:
I removed the x-ms-example tags from the operations and the error went away.

[veronicagg]

Are you creating this version based on an existing API version? which one? In order to get a better diff for review, we ask to have a commit first with the API version you copied from and then make the updates. You can use aka.ms/openapihub to Create API version based on existing, which will help making the commits I mentioned above and updating API versions as well as example files.

Please also update the readme.md file with the new file and a tag for this package.
Thanks!

[hendrytl]

Hi @veronicagg , This is a the first version of a data-plane API. So, there is no previous API to diff with. I originally tried using openapihub to create the first version, but the available options in the drop down didn’t support my scenario (existing RP, but no data-plane API). If it is supported and is the better way to do it I would be happy to do it. Since there isn’t an existing readme.md file, is there guidance on what should be in it? For our data-plane api we already have a python sdk and a C# sdk that have been hand authored.

[veronicagg]

@hendrytl Thanks for pointing out the scenario in openapihub, I'll follow up. I see that you added the readme already, and thanks for clarifying that you're not planning on having auto-generated SDKs. thanks!

[veronicagg]

@hendrytl will you be adding x-ms-examples to this PR? see CI failure https://dev.azure.com/azure-sdk/public/_build/results?buildId=21773&view=logs&jobId=688669d0-441c-57c3-cf6d-f89a22ccfa5d&taskId=923b5a90-e462-5994-c166-86509c6bf5f2&lineStart=77&lineEnd=78&colStart=1&colEnd=1
These examples are used for docs.com documentation.

[hendrytl]

The review is scheduled with Azure API review board today. @hendrytl<https://github.com/hendrytl> have you had this APIs reviewed by the Azure API review board?

[hendrytl]

@veronicagg We are planning on adding examples, but it will take some time as there are about 70 operations to add examples for. Is the check-in contingent on having all the examples there or can we add them over time?

[veronicagg]

@hendrytl ok, we prefer to have examples checked in with the specs, if you think you won't make that, you can add examples later, please know that if you're planning to generate documentation, it will be missing examples. The error for x-ms-examples required will be reported until they are added.
Also, your suppression for the error on the delete operation was approved, feel free to add it back to the readme.md file.

[veronicagg]

@hendrytl this PR is fine from my side, pending approval from API review board. thanks!

[veronicagg]

@hendrytl any updates on this PR? are you going through API review?

[hendrytl]

Hi Veronica, We’ve had two API reviews with the API Review Board so far. We are addressing their feedback and plan to have a new iteration with the feedback incorporated by Tuesday for review. From: Veronica Giaudrone <notifications@github.com> Sent: Friday, May 3, 2019 10:12 AM To: Azure/azure-rest-api-specs <azure-rest-api-specs@noreply.github.com> Cc: Todd Hendry <hendrytl@hotmail.com>; Mention <mention@noreply.github.com> Subject: Re: [Azure/azure-rest-api-specs] Create AzureMachineLearning.json data-plane API. (#5734) @hendrytl<https://github.com/hendrytl> any updates on this PR? are you going through API review? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#5734 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIZH5NM77Q3VMEC4WM7SQJ3PTRW4JANCNFSM4HHTGXUA>.

[veronicagg]

@hendrytl I'm changing roles, so I'm assigning this review to @amarzavery to help you complete it. Let us know if you'll be making more changes or we should take another look. Thanks!

[amarzavery]

spell check issues that need to be fixed.

specification/machinelearningservices/data-plane/Microsoft.MachineLearningServices/preview/2019-05-01/hyperdrive.json:54:32 - Unknown word (experiement)
specification/machinelearningservices/data-plane/Microsoft.MachineLearningServices/preview/2019-05-01/hyperdrive.json:107:32 - Unknown word (experiement)

I'm not required to review this PR as I'm not longer in the team responsible for the review

[johanste]

The swagger looks correct. There may be some custom extensions needed to optimize code generation. @amarzavery , once you get go-ahead, can you double-check readme.ms:s and merge if everything looks good?