Update maestro version to use Github url while publishing to BAR #3908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…provements needed. (#3702) When connected to a codespaces sesssion, we are going to need to call the server instance to get embedded license files and embedded icons (for packages not accessed via search to http feeds). In order to make that work well, we need to change our Icon fetching to be more async. This change doesn't add the codespaces side of things yet...is just trying to make our current icon loading as good, and better than it is now. The ViewModel.IconUrl property now has a matching IconBitmap property...and IconBitmapStatus Since 2016, we've used a ValueConverter (runs on UI thread only) to convert the Url to a BitmapImage that an Image element could show. This approach causes a UI delay when network retrieval of images is slow. We believe this work should fix that. In order to move off the UI thread...we moved the download into background work that IconBitmap getter kicks off. We rely on INotifyPropertyChanged to notify databinding later, that the IconBitmap value has changed on the background thread. Binding can update UI properties on UI Thread that were modified on a viewmodel in a background thread(s). ErrorFloodGate.cs - made this thread safe. Testing/Validation Tests Added: Yes Validation: testing with instrumented version of UI to see where each image came from (memorycache, download, default, defaultduetonetworkproblem, etc...). tested with clumsy to slow network, drop packets, etc...
Disable cpvm transitive pinning.
* Move output paths default initialization out of the target This fixes a host of path related issues when doing a customized build with Pack targets. It also obsoletes the 'PackageOutputPath' in the SDK's 'DefaultOutputPaths' targets. It also ensures non-sdk style projects doesn't have to specify some default paths. * Remove default value to PackageOutputPath The Default is now implied and points to the same directory. It is now redundant, and by removing it, the tests should not fail. * Added new Tests to check default output paths - Checks the default output paths from Project/Solution builds. - Check both the default and custom paths from continuous Project/Solution builds. * Remove duplicate logic inside the target The duplicate logic is not needed. (edited anyway but will push if anyone approves)
…application.current is null (#3725)
…#3703) * Made creation of uninstall actions run in parallel. * Address code review comments by @dtivel * Add unit tests for covering new `PreviewProjectsUninstallPackageAsync` method in NuGetPackageManager. * Address 1 more code review comment from dtivel. * Add unhappy path unit test. * Address more code review comments by dtivel. * Fix rebasing to dev. * Add another perf improvement for BuildIntegratedNuGetProject type projects. BuildIntegratedNuGetProject project can batch eval of DependencyGraphRestoreUtility.PreviewRestoreProjectsAsync. * Fix logic error for non-builtIntegrated projects. * Remove optimization for msbuild package.config type projects since they're not part of this optimization scope. * Remove unnecessary comment. * Fix formatting. * Address review by Nikolche. * Fix flaky test due. * Remove unused variables from test. Co-authored-by: Erick Yondon <eryondon@microsoft.com>
* Asynchronize access to IVsHierarchy. * Reverting changes to VsTemplateWizard.cs * Reverting changes to VsFrameworkCompatibilityTests.cs * Fixing build break. * Fixing public API in InternalAPITestHook. * ProjectType: Using HashSet instead of arrays. * LegacyPackageReferenceRestoreUtilityTests: Avoid duplicate calls. * Fix CpsPackageReferenceProjectProvider.cs after mismerge on rebase. * Remove unused GetAllEnvDTEProjects method. * Ensure OnEnvDTEProjectAdded/Renamed is executed in entirety before continuing. * Fix whitespace. Co-authored-by: Srdjan Jovcic <srdjanj@microsoft.com>
…he format check status (#3745)
…ng package search recommendations (#3825)
* Deprecation and Installed version no longer overlap * Remove inner Grid, add Column for Install down-arrow
…mand line, PMC (#3796) * Make PackageReference error handling more uniform across VS and command line, PMC. Let finish with warning instead of fail. Clean up * Remove changes not helping user. * Address code review comment by Andy * Remove unneeded comment * Add end to end test for PackageReference NU1604 error handling is different across VS and command line(NuGet/Home#9289) * Clean up end to end test file. * Add comment for 'Version' is not specified. * Move end to end test from NetCoreProjectTest to LegacyPackageRefProjectTest * Clean up new end2end test * Address latest PR comment by Nikolche
…pear correctly when selected in all themes. Also fixed the dashed border color of the Dependencies TreeView control for all themes. (#3848)
…ane in PM UI (#3842) * Only get metadata for the selected specific version for the details pane in PM UI * Add new method to the interface to avoid casting * Add unit tests * CR feedback, check for null before await * Fix whitespace
* Update Apex/FluentAssertions binaries * Change tests to ignore origin expected values for manually created data * Updated expected value * For Apex tests only leave VS open if the Environment variable is found * Add wait for DTE command to be available for Apex tests * Only invoke action completed after everything is done * Extend timeout duration for waiting for package to be intalled/updated/uninstalled * Remove check for cacheInitialized since it happens in the method call and that is surrounded by a needed lock * CR Feedback, log warning if command is unavailable
* Event to track how many times commands are executed on PMC. * Batch count of commands executed on PMC. * Fix format. * Add telemetry for how many times PMC was openened. Add telemetry for if PMC opened by default without user gesture. Add telemetry for how many times powershell commands executed. * Add code comment for automatically loaded PMC. * There are 2 seperate instances of PowerShellHost.cs can be created for PM UI and PM PMC. So make change to accommodiate this concern. * Combine 2 events make less number of event (just 1) to emit. * Fix typos. * Add actual origin which caused init.ps1 to run into telemetry. * Make names of telemetry event a constants. * Get donnie's advise for naming. * Remove init.ps1 telemetry because current scenario doesn't capture initial run of install new package with init.ps1. It's bit complicated. * Address Andy's code review comment. * Remove unused variable. * Send single event for both PMUI and PMC powershell events. * Make powershell telemetry works for with and without solution load. * No need to emit separate nugetvssolutionclose if there were no solution at all. * Refactor code so it's not much mix too much telemetry code into other code. * Add telemetry detecting Nuget command and load of init.ps1 for packages. * Move telemetry logic into seperate class VsPowerShellHostTelemetryEmit for emitting telemetry in PowerShellHost.cs * Fix formatting. * Remove manually typed consts with centralized one. * Move INuGetTelemetryAggregator so we don't have to publish new api. * Clean up * Fix typos * Start recording PMC usage without any solution load as seperate 'NuGetVSInstanceClose' event with 'SolutionLoaded' = false flag. Otherwise it's almost impossible to separate them. * Clean up * Add missing telemetry property * INuGetTelemetryCollector doesn't need to be Lazy since it's used immediately. * Address code review comment by Nikolche. * Remove unnecessary load of assembly. * Revert unneeded change. * Separate telemtry collector and emitter. * Move solution events to VSSolutionManager.cs * Make telemetry collector thread safe. * Refactor to use separate telemetry-event classes. * Correct class name same to file name. * Address PR comment by Fernando * Fix typo. * Correct event class names * Clean up and improve Powershell/PowershellTelemetryEmitter. * Fix typos. * Stop passing telemetry event between different methods. * Improve reaadability * Move no any solution is loaded and not executed any command logic to PowerShellHostTelemetryProcessor.cs * Correct prefix . * Refactor whole design after consulting with Andy. * Fix reopen flag might not work from dispose on PMC window. * Correct window count logic. * Improve formatting and fix PMC, PMUI loaded not set from after load from init.ps1 * Correct solution count. * Address PR comment Nkolche. * Address remaining review comments from Andy. * Clean up fix and fix typos. * Fix if PMC opened without solution then that window load is not counted. * Address PR comments by Fernando. * Address latest Andy's comments (removing prefix etc) * Address latest PR comment from Andy and Fernando. Now solution close event called vs/nuget/solutionclose and vs instance close event called vs/nuget/instanceclose. * Fix naming conventions.
…ontrast ratio in Light theme and use the correct colors for doc well UI (#3858)
…date package operation (#3859) Fix NuGet/Home#10483
* pack tests * output empty frameworkRef groups
…elated to PMC and Powershell usage (#3863) * Address missed PR comments from Nikolche. * Use static import suggested by Nikolche. * Address comment from Nikolche: parameter names have to be camel case. * Correct Namespace.
…Toggle Pattern (#3857) * Create Toggleable Automation Peer for ListBox
Contributor
Author
|
closing this one for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
Regression? Last working version:
Description
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation
Related to Translate Nuget Azdo url to Github url dotnet/arcade-services#1518
Test build -> https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4482024&view=results