Move the format check to allow running the unit tests regardless of the format check status #3745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/616
Regression: No
Fix
Details:
While I do believe that the format check is necessary and should block merges, I do think there's value in running the tests beyond that.
I recently got bit by this because the linux & mac tests did run, but the windows ones didn't.
See https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4187571&view=ms.vss-test-web.build-test-results-tab.
Testing/Validation
Tests Added: No
Reason for not adding tests: Infrastructure change
Validation: