-
Notifications
You must be signed in to change notification settings - Fork 738
add condition for excluding a specific tfm build output from package #3810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Anipik Can you please keep the PR template? Can you please add tests in https://github.com/NuGet/NuGet.Client/blob/dev/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/PackCommandTests.cs. Also make sure you see my latest comment in the issue. |
|
@nkolev92 i added the test and template. |
nkolev92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
|
The build failed because of formatting issues:
Can you please fix the formatting? Our instructions were recently updated with that: https://github.com/NuGet/NuGet.Client/blob/dev/CONTRIBUTING.md#build. Happy with this change? |
erdembayar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix formatting I commented on line.
test/NuGet.Core.FuncTests/Dotnet.Integration.Test/PackCommandTests.cs
Outdated
Show resolved
Hide resolved
|
@nkolev92 @erdembayar i pushed the change yesterday. It seems like CI is stuck |
|
CI doesn't runt automatically for external forks. I've kicked it off again |
|
@nkolev92 the ci is green, can we go ahead and merge this one ? |
|
cc @erdembayar for the final merge |
Can you take a look here? It looks it's ready to merge. |
Bug
Fixes: NuGet/Home#10396
Regression: No
Fix
Details: Currently we are using the IncludeBuildOutput Variable as on outerbuild parameter to include the build output for the tfms. Adding it as condition on innerbuild target helps it to add includeOutput for specific tfms.
Testing
Tests Added: Yes