Fix InternalsVisibleTo for unsigned builds #3723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
reviewed
Oct 21, 2020
nkolev92
approved these changes
Oct 22, 2020
nkolev92
added
Approved for CI
Community
zivkan
force-pushed
the
marcink-assemblyinfo-20201021
branch
from
5e421d5 to
9ffd3d9
Compare
zivkan
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#10173
Fix
Simple change to fix the build of NuGet.Client solution when signing is disabled.
It follows the same pattern as other
AssemblyInfofiles in this repository, e.g.: https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.Common/Properties/AssemblyInfo.csTesting/Validation
Tests Added: No
Reason for not adding tests: It would require building the whole solution twice, first time when signing is enabled and second time when signing is disabled. Disabling assembly signing is such a niche use case so I don't think it is worth adding tests for it.