error when missing tpv and platform present#3691
Merged
Conversation
zkat
force-pushed
the
dev-zkat-net5-missing-tpv-error
branch
from
d5a775b to
5c7a7ef
Compare
zkat
force-pushed
the
dev-zkat-net5-missing-tpv-error
branch
from
5c7a7ef to
e5206dd
Compare
zkat
force-pushed
the
dev-zkat-net5-missing-tpv-error
branch
from
e5206dd to
dbd5e0f
Compare
dominoFire
reviewed
Oct 16, 2020
src/NuGet.Core/NuGet.Packaging/Rules/TargetFrameworkMissingPlatformVersionRule.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging/Rules/TargetFrameworkMissingPlatformVersionRule.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging/Rules/TargetFrameworkMissingPlatformVersionRule.cs
Outdated
Show resolved
Hide resolved
nkolev92
reviewed
Oct 16, 2020
src/NuGet.Core/NuGet.Packaging/Rules/TargetFrameworkMissingPlatformVersionRule.cs
Outdated
Show resolved
Hide resolved
erdembayar
reviewed
Oct 19, 2020
src/NuGet.Core/NuGet.Packaging/Rules/TargetFrameworkMissingPlatformVersionRule.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@nkolev92 is this what you meant? |
Member
|
Yep, looks like the correct place for the validation. |
Contributor
Author
|
Tests are pushed. Providing everything passes, this is all the code to review, I think. |
nkolev92
approved these changes
Oct 21, 2020
Member
nkolev92
left a comment
nkolev92
left a comment
There was a problem hiding this comment.
LGTM. 👏 👏 👏 👏 👏
I think we can add a few more tests, but looks good beyond that.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#9441
Regression: No
Fix
This makes pack and restore fail if there's a framework with a platform but without a
Testing/Validation
Tests Added: Yes
Validation:
I manually checked it works for dependencygroups