Fixed the styles of the Dependencies tree's root nodes and dashed border #3848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donnie-msft
approved these changes
Jan 15, 2021
Contributor
donnie-msft
left a comment
donnie-msft
left a comment
There was a problem hiding this comment.
Nice! Any reason not to set that style on all TreeViews instead of just this one?
…orrectly when selected in all themes. Also fixed the border color of the Dependencies TreeView control for all themes.
jebriede
force-pushed
the
dev-jebriede-FixDependenciesColorsPMUI
branch
from
5d08c2f to
b5d831a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the style of the Dependencies tree's root nodes so the roots appear correctly when selected in all themes. Also fixed the dashed border color of the Dependencies TreeView control for all themes.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/715
Regression: No
Fix
Details: The Dependencies TreeView was setting an explicit foreground color which was overriding the color change when the node was selected. Removed the explicit color setting and added a style that applies to all root nodes that gives it the right color. Also applied the FocusVisualStyle for all themed controls so the dashed border would look correct in the dark theme as well as all others.
Testing/Validation
Tests Added: No
Reason for not adding tests: Fix is purely visual in the UI
Validation: For each theme, tabbed into the Dependencies tree view, observed the border was the appropriate color for the theme, then pressed the Down arrow key which selects the root node of the tree, and using Accessibility Insights, validated that the color ratio of the text to background was greater than 4.5:1.