Use V3 for DncEng BAR publishing #3731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
added
Approved for CI
Community
Contributor
Author
|
Test promotion build -> https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=4184770&view=results
|
Contributor
Author
mmitche
reviewed
Oct 29, 2020
Contributor
|
I'd run one more build to make sure that looks correct in the merged manifest, but LGTM otherwise. |
Contributor
Author
|
@zivkan is running an another build. I will post my result here after. |
zivkan
approved these changes
Oct 29, 2020
|
|
||
| <PropertyGroup Condition=" '$(Version)' == '' "> | ||
| <Version>$(SemanticVersion)$(PreReleaseInformationVersion)</Version> | ||
| <Version Condition="'$(BUILD_SOURCEVERSION)' != '' AND '$(IsCommandLinePackage)' != 'true'">$(SemanticVersion)$(PreReleaseInformationVersion)+$(BUILD_SOURCEVERSION)</Version> |
Member
There was a problem hiding this comment.
In case anyone in my team sees this and wonders why, there's no benefit to adding the commit hash to the end of the string. Looking at nuget.org, no other packages do this, including System.* packages from the dotnet team. Our nuspec still has the commit hash, to enable source link, so anyone who really wants the commit hash can still get it.
mmitche
approved these changes
Oct 29, 2020
Contributor
Author
|
Manifest looks good |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V3 onboarding
This PR uses maestro.task from general testing