added a unit test to solution explorer dependencies tree generation logic #3622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
approved these changes
Sep 1, 2020
nkolev92
reviewed
Sep 9, 2020
...ualStudio.Implementation.Test/SolutionExplorer/Models/AssetsFileDependenciesSnapshotTests.cs
Show resolved
Hide resolved
kartheekp-ms
force-pushed
the
dev-kartheekp-ms-solutionexplorer-dependencies
branch
from
06a0c8e to
8768c91
Compare
kartheekp-ms
force-pushed
the
dev-kartheekp-ms-solutionexplorer-dependencies
branch
2 times, most recently
from
fa35201 to
8d28baa
Compare
kartheekp-ms
force-pushed
the
dev-kartheekp-ms-solutionexplorer-dependencies
branch
from
019051c to
77ea6d5
Compare
donnie-msft
reviewed
Oct 14, 2020
...ualStudio.Implementation.Test/SolutionExplorer/Models/AssetsFileDependenciesSnapshotTests.cs
Outdated
Show resolved
Hide resolved
...ualStudio.Implementation.Test/SolutionExplorer/Models/AssetsFileDependenciesSnapshotTests.cs
Outdated
Show resolved
Hide resolved
...ualStudio.Implementation.Test/SolutionExplorer/Models/AssetsFileDependenciesSnapshotTests.cs
Outdated
Show resolved
Hide resolved
...ualStudio.Implementation.Test/SolutionExplorer/Models/AssetsFileDependenciesSnapshotTests.cs
Outdated
Show resolved
Hide resolved
kartheekp-ms
force-pushed
the
dev-kartheekp-ms-solutionexplorer-dependencies
branch
from
77ea6d5 to
84dd303
Compare
nkolev92
approved these changes
Oct 19, 2020
kartheekp-ms
deleted the
dev-kartheekp-ms-solutionexplorer-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#9971
Regression: No
Fix
Details: Added a unit test to to compare lock file target libraries in
project.assets.jsonfile with the libraries in the Dependencies tree.Testing/Validation
Tests Added: Yes
Reason for not adding tests:
Validation: