Do not require nuget.org to be only source when making recommendations #3825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
approved these changes
Jan 7, 2021
Member
|
Hey @birgithi Can you please use the PR template and create an issue? |
donnie-msft
approved these changes
Jan 7, 2021
Contributor
Author
|
I created issue NuGet/Home#10433 and updated the description. |
rrelyea
approved these changes
Jan 7, 2021
birgithi
force-pushed
the
dev-birgithi-fix-sources
branch
from
bdb3e6b to
48da6b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: NuGet/Home#10433
We decided that the recommender should make recommendations when one of the sources was nuget.org. Previously we had required that nuget.org was the only source.
This was fixed, but the change was reverted during some of the codespaces work in #3797
This just re-does the earlier fix.