PM UI: propagate implicit actions for "Preview Changes" summary in update package operation #3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbanni
reviewed
Jan 22, 2021
src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Services/NuGetProjectManagerService.cs
Outdated
Show resolved
Hide resolved
donnie-msft
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#10483
Regression: Yes
Fix
Details: For PackageReference-(.NET SDK-style)-based projects, updating an installed package involves other implicit actions (like first uninstalling the existing package). Propagating these implicit actions from server to client are necessary for the client to generate an update summary in the "Preview Changes" dialog.
Testing/Validation
Tests Added: Yes
Reason for not adding tests:
Validation: Manually validated against 16.6.5.
CC @rrelyea, @sbanni