PM UI: batch project selection updates in solution PM UI #3746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrelyea
approved these changes
Oct 30, 2020
Contributor
rrelyea
left a comment
rrelyea
left a comment
There was a problem hiding this comment.
looks good.
@donnie-msft - should ideally look at changes in these components as well.
donnie-msft
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#10112
Regression: Yes
Fix
Details: Before this change, selecting all projects as targets for a package install in the PM UI Browse tab would trigger a
SelectedChangedevent for each project. Each event would recalculate the checked state of the "select all projects" checkbox, create a versions list, and update the enable state of the install/uninstall buttons. After this change, the work previously done by the event handler is executed once after all projects have been selected or unselected.With the NuGet.Client solution (82 projects), the performance of checking the "select all projects" checkbox went from 364 ms to 13 ms.
Testing/Validation
Tests Added: No
Reason for not adding tests: UI performance scenario
Validation: manual validation