Merged
Conversation
This code closes the palette on *any* network event, including it getting established. This made tests like "Create a few projects using the default project name" unreliable. Also adds a block comment about how we should do something more sophisticated than bail out in the future.
Honoring exhausting hook dependency checks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6265 +/- ##
=======================================
Coverage 84.90% 84.90%
=======================================
Files 109 109
Lines 44842 44842
=======================================
Hits 38073 38073
Misses 6769 6769
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Just hit retry for a second time. |
Contributor
|
Thank you for all this work!! 🤞 |
pierremtb
approved these changes
Apr 10, 2025
Contributor
|
Okay I can see the E2e tests that are failing are the hover segment overlays again, which was causing us issues, but than they were not, but obviously they are again, so I'll look into those now. |
This was referenced Apr 11, 2025
modeling-app-github-app bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
* fix: increasing timeout to reduce failures..? * fix: removing debugging code * Remove unnecessary pixel color check * Only close the command palette on disconnection events This code closes the palette on *any* network event, including it getting established. This made tests like "Create a few projects using the default project name" unreliable. Also adds a block comment about how we should do something more sophisticated than bail out in the future. * Show a toast to explain why the user just lost their command flow * Remove unnecessary click in test. `fill` focuses already * Oop don't spam this disconnection toast if the palette isn't open Honoring exhausting hook dependency checks * Skip circle snapshot test, it's being weird * Disable the export button if engine connection is unavailable * Refactor useDemoCode to hopefully be more reliable * allow weak connections to receive demo code * revert Refactor useDemoCode to hopefully be more reliable Commit: 2625c14 [2625c14] --------- Co-authored-by: Kevin Nadro <kevin@zoo.dev> Co-authored-by: Jace Browning <jacebrowning@gmail.com> Co-authored-by: Andrew Varga <grizzly33@gmail.com>
Contributor
|
Oh never mind. |
jacebrowning
added a commit
that referenced
this pull request
Apr 11, 2025
* main: #6182 Improve calculate_circle_center (#6192) make sure the nix flake never breaks (#6273) Add CSG operations to the artifact graph (#6104) refactor: Change to use topLevelModule helper function (#6264) Remove experimental warning on whole-module imports (#6240) Insert a newline between block comments and attributes (#6250) Remove import function from std (#6241) Fix vscode lsp bugs (#6271) bump kcl friends (#6272) Bump modeling api & pull thru csg endpoints (#6245) Franknoirot/adhoc/improve e2e (#6265) Fix URL encoded names after rename to Zoo Design Studio (#6269) Repetitive structs removed for import file extensions (#6211)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging several PRs into one to see if the combined changes fair well. This is main with the commits from the following PRs merged in: