Skip to content

Bump modeling api & pull thru csg endpoints#6245

Merged
jessfraz merged 13 commits intomainfrom
bump-modeling-apoi
Apr 11, 2025
Merged

Bump modeling api & pull thru csg endpoints#6245
jessfraz merged 13 commits intomainfrom
bump-modeling-apoi

Conversation

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Apr 10, 2025

No description provided.

@qa-wolf
Copy link

qa-wolf bot commented Apr 10, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel
Copy link

vercel bot commented Apr 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Apr 10, 2025 11:53pm

@Irev-Dev
Copy link
Contributor

Irev-Dev commented Apr 10, 2025

we will eventually wanna call mikes get object ids in the scene to figure out what solids are left to return back to the user

Yeah maybe, hard to wrap my head around it, my main concern is to make sure we update the artifactGraph accordingly, but knowing solid ids will be important for selecting the result of one CSG to do another one (as that's the only time we set the engine selection filter to objects)

We'll mess with it a bunch to see what needs to happen.

@jessfraz
Copy link
Contributor Author

jessfraz commented Apr 10, 2025

yeah i need to know which of the solids you passed in still exist after this operation to return them back out, i personally need that one, or else i might return one that is now gone forever

@jessfraz jessfraz force-pushed the bump-modeling-apoi branch from cab8978 to 0d12b16 Compare April 10, 2025 20:34
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@jessfraz jessfraz force-pushed the bump-modeling-apoi branch from aeb5304 to ce6d12a Compare April 10, 2025 20:59
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 10, 2025

CodSpeed Walltime Performance Report

Merging #6245 will degrade performances by 14.27%

Comparing bump-modeling-apoi (05fef09) with main (df6f571)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 46 improvements
❌ 7 regressions
✅ 39 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
execute_80-20-rail 3.4 s 3.9 s -12.07%
parse_80-20-rail 9.1 ms 7.7 ms +16.88%
parse_ball-bearing 3.9 ms 3.3 ms +17.37%
parse_bench 3.7 ms 3.3 ms +13.56%
parse_bracket 2.8 ms 2.4 ms +15.81%
execute_car-wheel-assembly 20.4 s 17.8 s +15.06%
parse_car-wheel-assembly 399.3 µs 348.6 µs +14.56%
parse_color-cube 2.8 ms 2 ms +38.03%
parse_cycloidal-gear 4.2 ms 3.8 ms +12.46%
execute_dodecahedron 1.5 s 1.7 s -14.27%
parse_dodecahedron 12.5 ms 10.4 ms +19.7%
execute_dual-basin-utility-sink 4.3 s 3.7 s +16.7%
parse_dual-basin-utility-sink 15.5 ms 13.8 ms +12.17%
parse_enclosure 13.3 ms 10.5 ms +27.09%
parse_exhaust-manifold 12.5 ms 10.8 ms +15.76%
parse_flange 1.3 ms 1.1 ms +16.73%
parse_focusrite-scarlett-mounting-bracket 10 ms 8.5 ms +16.97%
parse_food-service-spatula 13.2 ms 11.6 ms +13.74%
execute_french-press 4.2 s 4.7 s -11.89%
parse_french-press 12.5 ms 10.7 ms +17.39%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Signed-off-by: Jess Frazelle <github@jessfraz.com>
jessfraz and others added 4 commits April 10, 2025 15:20
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@jessfraz jessfraz enabled auto-merge (squash) April 10, 2025 22:24
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@Irev-Dev
Copy link
Contributor

yeah i need to know which of the solids you passed in still exist after this operation to return them back out, i personally need that one, or else i might return one that is now gone forever

Just going of some of hand comments from Mike, It might be all new Ids for the solid itself.

@jessfraz
Copy link
Contributor Author

yeah i think we can get this in and fuck with it but if i have to i can reuse the clone code to repropulate the solid but would be hard we'd need new endpoints so i say we fuck around and find out and merge this for simple shit

@jessfraz
Copy link
Contributor Author

like recreating all the tags is going to be a cluster fuck if they are all new ids and i dont want this PR to gate that

Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 85.50725% with 20 lines in your changes missing coverage. Please review.

Project coverage is 84.89%. Comparing base (9d0518d) to head (05fef09).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rust/kcl-lib/src/std/csg.rs 82.75% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6245      +/-   ##
==========================================
- Coverage   84.90%   84.89%   -0.02%     
==========================================
  Files         109      109              
  Lines       44842    44964     +122     
==========================================
+ Hits        38073    38171      +98     
- Misses       6769     6793      +24     
Flag Coverage Δ
rust 84.89% <85.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jessfraz jessfraz disabled auto-merge April 11, 2025 01:30
@jessfraz jessfraz merged commit 3584484 into main Apr 11, 2025
57 of 59 checks passed
@jessfraz jessfraz deleted the bump-modeling-apoi branch April 11, 2025 01:30
jacebrowning added a commit that referenced this pull request Apr 11, 2025
* main:
  #6182 Improve calculate_circle_center (#6192)
  make sure the nix flake never breaks (#6273)
  Add CSG operations to the artifact graph (#6104)
  refactor: Change to use topLevelModule helper function (#6264)
  Remove experimental warning on whole-module imports (#6240)
  Insert a newline between block comments and attributes (#6250)
  Remove import function from std (#6241)
  Fix vscode lsp bugs (#6271)
  bump kcl friends (#6272)
  Bump modeling api & pull thru csg endpoints (#6245)
  Franknoirot/adhoc/improve e2e (#6265)
  Fix URL encoded names after rename to Zoo Design Studio (#6269)
  Repetitive structs removed for import file extensions (#6211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants