Bump modeling api & pull thru csg endpoints#6245
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Yeah maybe, hard to wrap my head around it, my main concern is to make sure we update the artifactGraph accordingly, but knowing solid ids will be important for selecting the result of one CSG to do another one (as that's the only time we set the engine selection filter to objects) We'll mess with it a bunch to see what needs to happen. |
|
yeah i need to know which of the solids you passed in still exist after this operation to return them back out, i personally need that one, or else i might return one that is now gone forever |
cab8978 to
0d12b16
Compare
aeb5304 to
ce6d12a
Compare
Signed-off-by: Jess Frazelle <github@jessfraz.com>
CodSpeed Walltime Performance ReportMerging #6245 will degrade performances by 14.27%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ❌ | execute_80-20-rail |
3.4 s | 3.9 s | -12.07% |
| ⚡ | parse_80-20-rail |
9.1 ms | 7.7 ms | +16.88% |
| ⚡ | parse_ball-bearing |
3.9 ms | 3.3 ms | +17.37% |
| ⚡ | parse_bench |
3.7 ms | 3.3 ms | +13.56% |
| ⚡ | parse_bracket |
2.8 ms | 2.4 ms | +15.81% |
| ⚡ | execute_car-wheel-assembly |
20.4 s | 17.8 s | +15.06% |
| ⚡ | parse_car-wheel-assembly |
399.3 µs | 348.6 µs | +14.56% |
| ⚡ | parse_color-cube |
2.8 ms | 2 ms | +38.03% |
| ⚡ | parse_cycloidal-gear |
4.2 ms | 3.8 ms | +12.46% |
| ❌ | execute_dodecahedron |
1.5 s | 1.7 s | -14.27% |
| ⚡ | parse_dodecahedron |
12.5 ms | 10.4 ms | +19.7% |
| ⚡ | execute_dual-basin-utility-sink |
4.3 s | 3.7 s | +16.7% |
| ⚡ | parse_dual-basin-utility-sink |
15.5 ms | 13.8 ms | +12.17% |
| ⚡ | parse_enclosure |
13.3 ms | 10.5 ms | +27.09% |
| ⚡ | parse_exhaust-manifold |
12.5 ms | 10.8 ms | +15.76% |
| ⚡ | parse_flange |
1.3 ms | 1.1 ms | +16.73% |
| ⚡ | parse_focusrite-scarlett-mounting-bracket |
10 ms | 8.5 ms | +16.97% |
| ⚡ | parse_food-service-spatula |
13.2 ms | 11.6 ms | +13.74% |
| ❌ | execute_french-press |
4.2 s | 4.7 s | -11.89% |
| ⚡ | parse_french-press |
12.5 ms | 10.7 ms | +17.39% |
| ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Just going of some of hand comments from Mike, It might be all new Ids for the solid itself. |
|
yeah i think we can get this in and fuck with it but if i have to i can reuse the clone code to repropulate the solid but would be hard we'd need new endpoints so i say we fuck around and find out and merge this for simple shit |
|
like recreating all the tags is going to be a cluster fuck if they are all new ids and i dont want this PR to gate that |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6245 +/- ##
==========================================
- Coverage 84.90% 84.89% -0.02%
==========================================
Files 109 109
Lines 44842 44964 +122
==========================================
+ Hits 38073 38171 +98
- Misses 6769 6793 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* main: #6182 Improve calculate_circle_center (#6192) make sure the nix flake never breaks (#6273) Add CSG operations to the artifact graph (#6104) refactor: Change to use topLevelModule helper function (#6264) Remove experimental warning on whole-module imports (#6240) Insert a newline between block comments and attributes (#6250) Remove import function from std (#6241) Fix vscode lsp bugs (#6271) bump kcl friends (#6272) Bump modeling api & pull thru csg endpoints (#6245) Franknoirot/adhoc/improve e2e (#6265) Fix URL encoded names after rename to Zoo Design Studio (#6269) Repetitive structs removed for import file extensions (#6211)
No description provided.