Skip to content

Remove experimental warning on whole-module imports#6240

Merged
jtran merged 3 commits intomainfrom
jtran/remove-warning
Apr 11, 2025
Merged

Remove experimental warning on whole-module imports#6240
jtran merged 3 commits intomainfrom
jtran/remove-warning

Conversation

@jtran
Copy link
Contributor

@jtran jtran commented Apr 9, 2025

Resolves #6236.

@jtran jtran requested a review from nrc April 9, 2025 20:24
@vercel
Copy link

vercel bot commented Apr 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Apr 11, 2025 4:03am

@qa-wolf
Copy link

qa-wolf bot commented Apr 9, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.94%. Comparing base (7bd5e73) to head (734fcd5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6240      +/-   ##
==========================================
- Coverage   84.95%   84.94%   -0.01%     
==========================================
  Files         108      108              
  Lines       45030    45017      -13     
==========================================
- Hits        38254    38241      -13     
  Misses       6776     6776              
Flag Coverage Δ
rust 84.94% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 9, 2025

CodSpeed Walltime Performance Report

Merging #6240 will improve performances by 12.8%

Comparing jtran/remove-warning (734fcd5) with main (7bd5e73)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 1 improvements
✅ 91 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
execute_mounting-plate 1.6 s 1.4 s +12.8%

@jtran jtran merged commit 0d89969 into main Apr 11, 2025
59 checks passed
@jtran jtran deleted the jtran/remove-warning branch April 11, 2025 04:22
jacebrowning added a commit that referenced this pull request Apr 11, 2025
* main:
  #6182 Improve calculate_circle_center (#6192)
  make sure the nix flake never breaks (#6273)
  Add CSG operations to the artifact graph (#6104)
  refactor: Change to use topLevelModule helper function (#6264)
  Remove experimental warning on whole-module imports (#6240)
  Insert a newline between block comments and attributes (#6250)
  Remove import function from std (#6241)
  Fix vscode lsp bugs (#6271)
  bump kcl friends (#6272)
  Bump modeling api & pull thru csg endpoints (#6245)
  Franknoirot/adhoc/improve e2e (#6265)
  Fix URL encoded names after rename to Zoo Design Studio (#6269)
  Repetitive structs removed for import file extensions (#6211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Whole Module Import Warning

2 participants