Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
force-pushed
the
jtran/csg-artifacts
branch
from
b4ef34c to
cc98892
Compare
jtran
force-pushed
the
jtran/csg-artifacts
branch
from
cc98892 to
ddd1d63
Compare
jtran
force-pushed
the
jtran/csg-artifacts
branch
from
705deaf to
fd8c5f8
Compare
I think this is just the usual id's transforming, i.e. segment ids become edge ids, and I guess the path id just becomes the main id for the solid. If you take a fairly complex solid, i.e. one with lots of sketchOnFaces, stacked on each other, and then you turn the engine selection filter to |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6104 +/- ##
==========================================
- Coverage 84.96% 84.95% -0.01%
==========================================
Files 108 108
Lines 45017 45115 +98
==========================================
+ Hits 38247 38327 +80
- Misses 6770 6788 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Add CSG operations to the artifact graph * Add tool IDs for subtract * Fix names to match modeling-cmds now that it's done * Update output since adding CSG ops * Update formatting * Add extra solid ids to the graph * Fix to not add duplicates to the graph
* main: #6182 Improve calculate_circle_center (#6192) make sure the nix flake never breaks (#6273) Add CSG operations to the artifact graph (#6104) refactor: Change to use topLevelModule helper function (#6264) Remove experimental warning on whole-module imports (#6240) Insert a newline between block comments and attributes (#6250) Remove import function from std (#6241) Fix vscode lsp bugs (#6271) bump kcl friends (#6272) Bump modeling api & pull thru csg endpoints (#6245) Franknoirot/adhoc/improve e2e (#6265) Fix URL encoded names after rename to Zoo Design Studio (#6269) Repetitive structs removed for import file extensions (#6211)
2 participants
Resolves #6103.
It's surprising to me that the boolean commands point to their constituent path IDs. My understanding is that they're supposed to be solids, not paths.