#6182 Improve calculate_circle_center

[andrewvarga]

Fixes #6182

This fixes the returned NaNs in this example kcl:

sketch001 = startSketchOn(XZ)
profile001 = startProfileAt([200.58, 199.26], sketch001)
  |> line(endAbsolute = [0, 0])
  |> arcTo({
       interior = [0, -99.85],
       end = [99.41, -99.85]
     }, %)

The existing implementation of calculate_circle_center returned NaN because of division by zeros when 2 points had the same x coordinates resulting in Infinite slopes.
I think instead of calculating slopes and handling special cases it's simpler and more robust to just solve the equations.
There are still edge cases like when the 3 points are collinear but that's handled now so at least it doesn't return NaNs.
A slightly different but still robust approach would be to still calculate the 2 bisectors and solving the line intersections.

Added some unit tests as well.

I think the intersect function could be reworked the same way without using slopes.

[qa-wolf]

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
modeling-app	✅ Ready (Inspect)	Visit Preview	Apr 11, 2025 8:48am

[codspeed-hq]

CodSpeed Walltime Performance Report

Merging #6192 will degrade performances by 14.92%

_{Comparing andrewvarga/6182/calculate-circle-center-edge-cases (fedf812) with main (c45c2e2)}

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 89 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
⚡	execute_80-20-rail	3.8 s	3.4 s	+11.69%
⚡	execute_gear-rack	1.7 s	1.5 s	+11.97%
❌	execute_socket-head-cap-screw	1.6 s	1.9 s	-14.92%

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (c45c2e2) to head (fedf812).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6192      +/-   ##
==========================================
+ Coverage   84.95%   84.97%   +0.01%     
==========================================
  Files         108      108              
  Lines       45121    45169      +48     
==========================================
+ Hits        38333    38381      +48     
  Misses       6788     6788              

Flag	Coverage Δ
rust	84.97% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jtran]

Missed opportunity to use TAU. We're big fans of tau 🙂

[andrewvarga]

Oh, I see, I've updated that :)