Chore: improving base case create project and settle in playwright test.#6248
Chore: improving base case create project and settle in playwright test.#6248
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Irev-Dev
left a comment
There was a problem hiding this comment.
15 seconds is pretty long.
Are there more underlying issues do you think, or it really just needs this long?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6248 +/- ##
=======================================
Coverage 84.90% 84.90%
=======================================
Files 109 109
Lines 44842 44842
=======================================
Hits 38073 38073
Misses 6769 6769
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey this got rolled into #6265, and it got things a little more solidly green. Nice work! |
Issue
running
yarn test:playwright:electron:local -g "Create project and load stress test" --repeat-each="10"would fail 30% of the time.Fix
Increase the timeout on the settle for the disabled button.
It always failed on
I did a massive debug print statement to see
isExeccuting,disableAllButtons, and the engine connection stateTests
With
15_000timeout.