Insert a newline between block comments and attributes#6250
Conversation
Signed-off-by: Nick Cameron <nrc@ncameron.org>
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6250 +/- ##
=======================================
Coverage 84.89% 84.89%
=======================================
Files 109 109
Lines 44964 44976 +12
=======================================
+ Hits 38171 38183 +12
Misses 6793 6793
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Walltime Performance ReportMerging #6250 will degrade performances by 16.62%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ❌ | execute_80-20-rail |
3.4 s | 4.1 s | -16.62% |
| ⚡ | parse_80-20-rail |
9.1 ms | 7.5 ms | +20.13% |
| ⚡ | parse_ball-bearing |
3.9 ms | 3.4 ms | +14.56% |
| ⚡ | parse_bench |
3.7 ms | 3.2 ms | +16.44% |
| ⚡ | parse_bracket |
2.8 ms | 2.5 ms | +12.15% |
| ⚡ | parse_car-wheel-assembly |
399.3 µs | 344.9 µs | +15.78% |
| ⚡ | parse_color-cube |
2.8 ms | 2 ms | +37.47% |
| ⚡ | parse_cycloidal-gear |
4.2 ms | 3.6 ms | +18.58% |
| ⚡ | parse_dodecahedron |
12.5 ms | 10.7 ms | +16.66% |
| ⚡ | parse_dual-basin-utility-sink |
15.5 ms | 13 ms | +19.56% |
| ⚡ | parse_enclosure |
13.3 ms | 10.7 ms | +23.65% |
| ⚡ | parse_exhaust-manifold |
12.5 ms | 10.7 ms | +16.69% |
| ⚡ | parse_flange |
1.3 ms | 1.2 ms | +12.4% |
| ⚡ | parse_focusrite-scarlett-mounting-bracket |
10 ms | 8.8 ms | +13.38% |
| ⚡ | parse_food-service-spatula |
13.2 ms | 11.4 ms | +16.04% |
| ⚡ | parse_french-press |
12.5 ms | 10.6 ms | +18.3% |
| ⚡ | parse_gear-rack |
2.5 ms | 2.2 ms | +14.84% |
| ⚡ | parse_gear |
9.5 ms | 8.3 ms | +14.86% |
| ⚡ | parse_gridfinity-baseplate-magnets |
16.5 ms | 13.8 ms | +20.01% |
| ❌ | execute_gridfinity-baseplate |
2.4 s | 2.7 s | -11.03% |
| ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Signed-off-by: Nick Cameron <nrc@ncameron.org> Co-authored-by: Jess Frazelle <jessfraz@users.noreply.github.com>
* main: #6182 Improve calculate_circle_center (#6192) make sure the nix flake never breaks (#6273) Add CSG operations to the artifact graph (#6104) refactor: Change to use topLevelModule helper function (#6264) Remove experimental warning on whole-module imports (#6240) Insert a newline between block comments and attributes (#6250) Remove import function from std (#6241) Fix vscode lsp bugs (#6271) bump kcl friends (#6272) Bump modeling api & pull thru csg endpoints (#6245) Franknoirot/adhoc/improve e2e (#6265) Fix URL encoded names after rename to Zoo Design Studio (#6269) Repetitive structs removed for import file extensions (#6211)
This fixes the immediate bug with #6244 but is not a total fix since any other bug in the unparser will cause similar problems.