Skip to content

make sure the nix flake never breaks#6273

Merged
jessfraz merged 11 commits intomainfrom
test-flake
Apr 11, 2025
Merged

make sure the nix flake never breaks#6273
jessfraz merged 11 commits intomainfrom
test-flake

Conversation

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Apr 11, 2025

  • bump modeling-cmds to get rid of error
  • bump kcl versions
  • make better auto completes for csg functions

Signed-off-by: Jess Frazelle <github@jessfraz.com>
@jessfraz jessfraz requested a review from iterion April 11, 2025 03:35
@vercel
Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Apr 11, 2025 6:03am

@jessfraz jessfraz enabled auto-merge (squash) April 11, 2025 03:35
@qa-wolf
Copy link

qa-wolf bot commented Apr 11, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.95%. Comparing base (5832890) to head (aedd331).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6273   +/-   ##
=======================================
  Coverage   84.95%   84.95%           
=======================================
  Files         108      108           
  Lines       45115    45121    +6     
=======================================
+ Hits        38327    38333    +6     
  Misses       6788     6788           
Flag Coverage Δ
rust 84.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jessfraz and others added 9 commits April 10, 2025 22:06
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@jessfraz jessfraz merged commit c45c2e2 into main Apr 11, 2025
62 checks passed
@jessfraz jessfraz deleted the test-flake branch April 11, 2025 06:27
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 11, 2025

CodSpeed Walltime Performance Report

Merging #6273 will degrade performances by 12.19%

Comparing test-flake (aedd331) with main (5832890)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 1 improvements
❌ 28 regressions
✅ 63 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
parse_80-20-rail 8.1 ms 9 ms -10.09%
parse_bench 3.4 ms 3.8 ms -10.02%
parse_bracket 2.6 ms 2.9 ms -11.07%
parse_car-wheel-assembly 363.8 µs 408.2 µs -10.87%
execute_cycloidal-gear 1.2 s 1.4 s -11.28%
parse_cycloidal-gear 3.8 ms 4.2 ms -10.38%
execute_dodecahedron 1.7 s 1.5 s +11.47%
parse_dodecahedron 11.1 ms 12.3 ms -10.35%
parse_enclosure 11 ms 12.3 ms -11.03%
parse_food-service-spatula 11.8 ms 13.2 ms -10.89%
parse_french-press 10.8 ms 12.3 ms -11.81%
parse_gear-rack 2.2 ms 2.5 ms -11.7%
parse_gear 8.6 ms 9.6 ms -10.28%
parse_gridfinity-baseplate-magnets 15.1 ms 16.8 ms -10.2%
parse_gridfinity-baseplate 9.4 ms 10.8 ms -12.19%
parse_gridfinity-bins-stacking-lip 22.3 ms 24.8 ms -10.16%
parse_gridfinity-bins 13.2 ms 14.7 ms -10.06%
parse_makeup-mirror 4.6 ms 5.2 ms -10.98%
parse_mounting-plate 3 ms 3.4 ms -11.3%
execute_parametric-bearing-pillow-block 2.6 s 2.9 s -11.3%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

modeling-app-github-app bot pushed a commit that referenced this pull request Apr 11, 2025
make sure teh nix flake never breaks

Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 11, 2025
make sure teh nix flake never breaks

Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 11, 2025
make sure teh nix flake never breaks

Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 11, 2025
make sure teh nix flake never breaks

Signed-off-by: Jess Frazelle <github@jessfraz.com>
jacebrowning added a commit that referenced this pull request Apr 11, 2025
* main:
  #6182 Improve calculate_circle_center (#6192)
  make sure the nix flake never breaks (#6273)
  Add CSG operations to the artifact graph (#6104)
  refactor: Change to use topLevelModule helper function (#6264)
  Remove experimental warning on whole-module imports (#6240)
  Insert a newline between block comments and attributes (#6250)
  Remove import function from std (#6241)
  Fix vscode lsp bugs (#6271)
  bump kcl friends (#6272)
  Bump modeling api & pull thru csg endpoints (#6245)
  Franknoirot/adhoc/improve e2e (#6265)
  Fix URL encoded names after rename to Zoo Design Studio (#6269)
  Repetitive structs removed for import file extensions (#6211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants