Skip to content

Fix vscode lsp bugs#6271

Merged
jessfraz merged 4 commits intomainfrom
fix-vscode-lsp
Apr 11, 2025
Merged

Fix vscode lsp bugs#6271
jessfraz merged 4 commits intomainfrom
fix-vscode-lsp

Conversation

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Apr 11, 2025

  • the adding of ${} at the end is now done on the code mirror side, we have playwright test autocomplete works so this is fine
  • added a test for untitled file thing and allowed it from the vscode plugin side

closes #6260 #6259

Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@qa-wolf
Copy link

qa-wolf bot commented Apr 11, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@jessfraz jessfraz requested a review from jtran April 11, 2025 01:03
@vercel
Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Apr 11, 2025 1:43am

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 98.83041% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.93%. Comparing base (3584484) to head (bb15580).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rust/kcl-lib/src/docs/kcl_doc.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6271      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.04%     
==========================================
  Files         109      109              
  Lines       44964    45104     +140     
==========================================
+ Hits        38171    38311     +140     
  Misses       6793     6793              
Flag Coverage Δ
rust 84.93% <98.83%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 11, 2025

CodSpeed Walltime Performance Report

Merging #6271 will degrade performances by 13.94%

Comparing fix-vscode-lsp (bb15580) with main (df6f571)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 4 improvements
❌ 4 regressions
✅ 84 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
execute_80-20-rail 3.4 s 4 s -13.94%
execute_car-wheel-assembly 20.4 s 18.5 s +10.7%
parse_color-cube 2.8 ms 2.4 ms +14.82%
execute_french-press 4.2 s 4.6 s -10.26%
execute_gridfinity-baseplate 2.4 s 2.8 s -11.56%
execute_kitt 4.6 s 5.1 s -10.38%
parse_router-template-cross-bar 6.3 ms 5.2 ms +20.85%
parse_router-template-slate 4.2 ms 3.5 ms +19.83%

@jessfraz jessfraz disabled auto-merge April 11, 2025 02:47
@jessfraz jessfraz enabled auto-merge (squash) April 11, 2025 02:47
@jessfraz jessfraz merged commit 1b8eee8 into main Apr 11, 2025
59 checks passed
@jessfraz jessfraz deleted the fix-vscode-lsp branch April 11, 2025 02:53
Copy link
Contributor

@jtran jtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

jacebrowning added a commit that referenced this pull request Apr 11, 2025
* main:
  #6182 Improve calculate_circle_center (#6192)
  make sure the nix flake never breaks (#6273)
  Add CSG operations to the artifact graph (#6104)
  refactor: Change to use topLevelModule helper function (#6264)
  Remove experimental warning on whole-module imports (#6240)
  Insert a newline between block comments and attributes (#6250)
  Remove import function from std (#6241)
  Fix vscode lsp bugs (#6271)
  bump kcl friends (#6272)
  Bump modeling api & pull thru csg endpoints (#6245)
  Franknoirot/adhoc/improve e2e (#6265)
  Fix URL encoded names after rename to Zoo Design Studio (#6269)
  Repetitive structs removed for import file extensions (#6211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KCL Autocomplete Always Ends with ${} Artifact in Cursor

3 participants