chore: stabilizing named views e2e tests#6246
Merged
jacebrowning merged 7 commits intomainfrom Apr 11, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
nadr0
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6246 +/- ##
=======================================
Coverage 84.97% 84.97%
=======================================
Files 108 108
Lines 45169 45169
=======================================
Hits 38381 38381
Misses 6788 6788
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacebrowning
approved these changes
Apr 10, 2025
Contributor
|
Hey this got rolled into #6265 so we could see a full green run, nice work! |
* main: #6182 Improve calculate_circle_center (#6192) make sure the nix flake never breaks (#6273) Add CSG operations to the artifact graph (#6104) refactor: Change to use topLevelModule helper function (#6264) Remove experimental warning on whole-module imports (#6240) Insert a newline between block comments and attributes (#6250) Remove import function from std (#6241) Fix vscode lsp bugs (#6271) bump kcl friends (#6272) Bump modeling api & pull thru csg endpoints (#6245) Franknoirot/adhoc/improve e2e (#6265) Fix URL encoded names after rename to Zoo Design Studio (#6269) Repetitive structs removed for import file extensions (#6211)
Contributor
|
It seems we are missing commits on |
modeling-app-github-app bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
* fix: moving toast application state: * fix: forgot the await on the expect calls, ts didn't yell at me? * fix: cleaning up the camera move e2e code * fix: lint,tsc,fmt * Unblock on macOS for now --------- Co-authored-by: Frank Noirot <frank@zoo.dev> Co-authored-by: Jace Browning <jacebrowning@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
named view playwright tests were flaky
Fix