Skip to content

Remove unnecessary pixel color check#6262

Closed
jacebrowning wants to merge 2 commits intomainfrom
remove-pixel-check
Closed

Remove unnecessary pixel color check#6262
jacebrowning wants to merge 2 commits intomainfrom
remove-pixel-check

Conversation

@jacebrowning
Copy link
Contributor

With the same motivation as #6225, the point of this test is to capture real-world prompts for Text-to-CAD analysis. We don't need to be checking specific pixel colors in order to do that, which is unreliable.

@jacebrowning jacebrowning self-assigned this Apr 10, 2025
@vercel
Copy link

vercel bot commented Apr 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Apr 11, 2025 0:21am

@qa-wolf
Copy link

qa-wolf bot commented Apr 10, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.92%. Comparing base (843e772) to head (df4d891).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6262   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files         109      109           
  Lines       44842    44842           
=======================================
  Hits        38083    38083           
  Misses       6759     6759           
Flag Coverage Δ
rust 84.92% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacebrowning
Copy link
Contributor Author

This was applied in #6265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants