Only close the command palette on disconnection events#6263
Closed
franknoirot wants to merge 5 commits intomainfrom
Closed
Only close the command palette on disconnection events#6263franknoirot wants to merge 5 commits intomainfrom
franknoirot wants to merge 5 commits intomainfrom
Conversation
This code closes the palette on *any* network event, including it getting established. This made tests like "Create a few projects using the default project name" unreliable. Also adds a block comment about how we should do something more sophisticated than bail out in the future.
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jacebrowning
approved these changes
Apr 10, 2025
franknoirot
force-pushed
the
franknoirot/adhoc/close-cmd-bar-only-disconnect
branch
from
bde7140 to
d996da8
Compare
Honoring exhausting hook dependency checks
franknoirot
force-pushed
the
franknoirot/adhoc/close-cmd-bar-only-disconnect
branch
from
25718b0 to
39fb1bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6263 +/- ##
==========================================
+ Coverage 84.90% 84.93% +0.02%
==========================================
Files 109 109
Lines 44842 44842
==========================================
+ Hits 38073 38085 +12
+ Misses 6769 6757 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code closes the palette on any network event, including it getting established. This made tests like "Create a few projects using the default project name" unreliable.
Also adds a block comment about how we should do something more sophisticated than bail out in the future.