Don't bail command palette if there's no engineConnection#6286
Merged
Don't bail command palette if there's no engineConnection#6286
Conversation
The connection can't be bad if there is not yet `:galaxy-brain:`. But seriously this behavior regressed share links because we would bail from the command palette because the connection wasn't healthy.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6286 +/- ##
=======================================
Coverage 84.97% 84.97%
=======================================
Files 108 108
Lines 45169 45169
=======================================
Hits 38381 38381
Misses 6788 6788
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pierremtb
approved these changes
Apr 11, 2025
Contributor
pierremtb
left a comment
pierremtb
left a comment
There was a problem hiding this comment.
Tested locally! Thank you for the quick fix
modeling-app-github-app bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
…6286) The connection can't be bad if there is not yet `:galaxy-brain:`. But seriously this behavior regressed share links because we would bail from the command palette because the connection wasn't healthy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connection can't be bad if there is none yet
:galaxy-brain:.But seriously this behavior regressed share links because we would bail from the command palette because the connection wasn't healthy. This behavior was introduced in #5312 and not fixed by changes in #6265, only caught during smoke testing in #6283 luckily.