Merged
Conversation
- After changes in #9503 to make sending reports for the whole month easier, this updates the sending logic to check that for the last day of the month changelog: Internal, Reporting, Update monthly key metrics report
* Fix flaky spec around DST changes We use Zonebie so we are impacted by Europe's changes into and out of Daylight Savings Time as well as ours. Travel_to a date that does not include DST changes. [skip changelog] * Start printing ZONEBIE_TZ on CI * Add variable to explain significance of travel_to date --------- Co-authored-by: Jack Ryan <jack.ryan@gsa.gov>
- Remove Thread#abort_on_exception and throw first error directly on main thread - Disable Thread#report_on_exception because it adds a lot of noise to spec running - Add handling to reports for rate limiting queries that show the errors being hit changelog: Internal, Reporting, Improve error handling for Cloudwatch queries
- Still notify backend * Configurable error behavior * Add ApplicationHelper#page_title and an error class Co-authored-by: Andrew Duthie <aduth@users.noreply.github.com> changelog: Internal, Accessibility, Hide missing title errors from user
* add hybrid flow to analytics spec * fix hybrid test * changelog: Internal, Automated Teseting, Add hybrid flow to analytics spec * happy linting
An accessibility report revealed that the two forms on this page have a label of `""`. This is not great since they're both the same and empty. This commit adds an aria label to them, which will make it more accessible by adding the forms to the landmarks of the page. Notes: - I'm not sure the text for the button here is the best description of the form. But, it already has translations and gives us a starting point. We decided it was MVP. - SimpleForm auto-created an id for one of the forms that I had to override in order to make them consistent. See [this Slack thread](https://gsa-tts.slack.com/archives/C0NGESUN5/p1698872821571519) for more details. - The `hybrid_handoff` view is currently undergoing an A/B test. We decided rather than create a new context for these tests or only include them in either A or B, we would just duplicate the tests for now. * changelog: User-Facing Improvements, Doc Auth, Add aria labels to forms on hybrid handoff page Co-authored-by: John Maxwell <john.maxwell@gsa.gov> Co-authored-by: Brittany Greaner <brittany.greaner@gsa.gov>
* Update content on IPP Verify your identity view * Update content for We couldn’t verify your ID view * fix lint issues * changelog: User-Facing Improvements, In-person proofing, Update content to emphasize visiting the PO in IPP * Update content * update content * added testing * fix linter errors * updated po translation to be lower case * updated fr translation * update test description
* Add IconListComponent ViewComponent changelog: Internal, Performance, Reduce size of application stylesheet * Remove unreferenced view partial * Prefer state token over color * Use multiline block syntax * Indent Make comment
changelog: Internal, Code Quality, Refactor sign in selection presenters
* Revise title helper as getter setter changelog: Internal, Accessibility, Hide missing title errors from user * Update specs * Update application.html.erb_spec.rb
* Update SECURITY.md * Update local-development.md
* changelog: Internal, Authentication, remove platform auth setup feature toggle * fix and address comments * remove method calls/ * include set up
* Add specs for title helpers changelog: Internal, Accessibility, Hide missing title errors from user * Enable raised missing title errors in dev, test * Collapse stubbing before block to same scope as let * Move all raise stubbing to relevant context * Fix context block inaccuracy * Explicitly set raise_on_missing_title in application view spec
* Remove "monthly proofing report" - Most of the information is duplicated by "proofing rate report" * Remove placeholders for information no longer needed in report * Update Agency/Apps report - Clarify that states are treated as agencies - Add total row * Remove separate "total verified accounts" table - Included in total user count report changelog: Internal, Reporting, Update monthly key metrics report
* add phone with camera to ab test analytics * add phone_with_camera to analytics spec * update ab_test_analytics_concern_spec to inclide phone_with_camera * test phone question to detect setting phone_with_camera in idv_session * remove phone_with_camera logging from spec when idv_session not available * [skip changelog] * log phone_with_camera in hybrid document capture * check referer if user decides not to confirm cancel initiated from hybrid handoff page * happy linting * Send new phone_with_camera to FE for logging * Use new variable on FE for logging * Move phone_with_camera into ab test concern * Send BE value to FE in more places * Add phoneWithCamera to context * Revert incorrect change to ab test concern * Get phone_with_camera from session correctly in controllers * Add missing closing brackets on query selector * Add phone_with_camera to idv view * Fix js tests * Add missing test variable * log phone_with_camera on frontend image added events * init add params to idv_front_image_clicked * init add params to idv_back_image_clicked * Move phone_with_camera in controller hashes * Add analytics arguments to analytics service * Expand hash assignment to fix error * Update analytics tests * Make log merges work correctly in controller * Lint fixes * Add params to analytics methods * Trigger CI pipeline * Lint fixes --------- Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
changelog: Bug fixes, Emails, Use correct translation for email footer help text
* Update job to send enrollment code to pinpoint message. and have translation display that message. * Updates to spanish and french translations to incorporate reference code. * Updating notification test. Wanna see what gitlab does * Fixing var name in french translation * changelog: User-facing changes, In-person proofing, attach enrollment code to SMS message for reference during possible fraud * changelog: User-Facing Improvements, In-Person Proofing, attach enrollment code to SMS message for reference during possible fraud * Adding tests for english, spanish and french languages for SMS response * Linting * Add enrollment code formatter and small edit to es translation * Adding french translation and updating tests
* Lint analytics event exceptions on actual name changelog: Internal, Automated Testing, Improve developer experience of analytics event name linter * Use spec example with different event name
…18) (#9538) changelog: Internal, Reporting, Update monthly key metrics report
* add missing phone_with_camera to hybrid happy path * [skip changelog]
* fix missing attributes in logs * fix isDrop to mach Cloudwatch logs * define params * fix linting * changelog: Internal, Analytics, add missing analytics attributes * happy linting * fix rupocop en/disable for mixed case * fix signature for idv_capture_troubleshooting_dismissed * fix signature for idv_capture_troubleshooting_dismissed x2 * fix param tags * re-add mising **_extra param * Add missing attributes to frontend logger events changelog: Internal, Logging, Add missing attributes to frontend logger events * remove unused events --------- Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
changelog: Internal, Logging, Avoid logging request detail for session active routes
* Add BE feature flag for doc_auth_selfie_capture * Send selfie feature flag to FE * Use BE feature flag on FE * Extract featureflag object from BE string * Turn off Selfie feature flag in dev and test (already off in prod) * Add test with syntax issue * Get test working with correctly escaped quotes * Improve lint happiness * changelog: Internal, In-Person Proofing, Add feature flag for selfie feature
* Avoid appending info for ignored Lograge actions changelog: Internal, Logging, Avoid logging request detail for session active routes * Skip shortcut if ignore_actions not configured * Add specs for Lograge ignore logic
…9532) * changelog: Internal, tech debt, Break up MFA presenter class for Backup codes * update spec with class names * lint fix * add in missing non-phone option presenter * remove personal_key from login_label
This commit builds on #9509. That commit added the ability to write PII to the session under the profile ID associated with that PII. This commit starts using the functionality added in that PR to start writing both the pending and active profile to the session. Additionally in places where PII is written to the session outside the context of password authentication the corresponding profile ID is passed to the PII cacher. [skip changelog]
* Add basic routing and view. Draft redirection logic. * Add some radio buttons * Update app/controllers/idv/how_to_verify_controller.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Style it up * Lint it up * changelog: User-Facing improvements, In-Person Proofing, Add IPP opt-in page after agreement and before remote flow * 404 the page if disabled * Use a const for options * Update app/controllers/idv/how_to_verify_controller.rb Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> * Add entries for translations * Translate and analytics * Fix missing tags * Update app/controllers/idv/how_to_verify_controller.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * New analytics format * Prefer strings * Use constants this way * Move into a class * Scope styles to tablet * Impl mobile styling * Update correct translated alt tags * Include height * Add some validation and error messaging * Use height/width attrs to make lint happy * Run lint * Implement FlowStep policy API * Add some tests * Alphabetize! * Add controller spec * Remove unused utilities * use aria-labelledby pointing to the preceding paragraph instead of duplicating the label * Update app/controllers/idv/how_to_verify_controller.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Remove rails g boilerplate * Use standard tags and header tags * Remove duplicates * Cleanup * Split up and use troubleshoting options * Remove html translations * Capitalize! * Move exception to the _radio-button extension * Use correct flow policy key * Optimize! * Remove periods from link text * Add more spec; centralize the selection options into form * Use the radio_button helpers to save some manual wiring * Include hidden with same name * Change feature flag name * Require form selection * Update app/forms/idv/how_to_verify_form.rb Co-authored-by: Matt Wagner <mattwagner@navapbc.com> * Remove generated cruft and append _spec to the end of the test file * Remove unused verification options and auto freeze string literals * Lowercase post office translation * set title instead of calling as help * Update app/controllers/idv/how_to_verify_controller.rb Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Matt Wagner <mattwagner@navapbc.com>
* Update report mailer to use an PNG instead of an SVG changelog: Internal, Reporting, Fix alert formatting inside email
* Add passive liveness script conditional loading * Correctly remove script from page on unload * Only pass one variable instead of two * Use the actual feature flag from newly updated `main` * changelog: Internal, In-Person Proofing, Add AcuantPassiveLiveness JS script loading * Add opencv script that passive liveness depends on
The `SsnForm` class is a form object that does a lot of footwork to check if the SSN is unique and add that to the analytics. This form actually uses a service object to do that. This commit removes the middleman and calls the service object in the controller (actually it is a concern shared between 2 controllers) that previously consumed this form. [skip changelog]
* change incorrect code to incorrect verificaiton code * create new controller and route for enter code rate limit * set up new page for enter code rate limit * controller tests for rate limited * add translations * removed old enter code rate limit html * add feature test for rate limiting * add changelog changelog: User-Facing Improvements, IdV By Mail, Add a rate limit screen for GPO * add line breaks * normalize yaml * remove flash if rate limited * fix translation * remove unused translations * linty mclinterson * remove the line breaks * normalize yaml * path -> url in tests * use an actual gpo pending profile * path -> url & try_again_later -> rate_limited * re-delete enter_code/rate_limited
Bumps [phonelib](https://github.com/daddyz/phonelib) from 0.8.4 to 0.8.5. - [Release notes](https://github.com/daddyz/phonelib/releases) - [Changelog](https://github.com/daddyz/phonelib/blob/master/CHANGELOG.md) - [Commits](daddyz/phonelib@v0.8.4...v0.8.5) --- updated-dependencies: - dependency-name: phonelib dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Move remote Ssn show template to shared/ssn changelog: Internal, Ssn step, unify underlying code for remote and in person ssn pages * Add step_indicator_steps and url_for to common ssn template * Use shared template from in person SsnController * Refactor in_person SsnController to match remote SsnController * Replace updating_ssn? method with @ssn_form.updating_ssn? * Use flash[:error] instead of @error_message instance variable * Use idv_session.flow_path in both controllers * Comments to keep controllers in sync * Start updating in person view spec * fix the view spec and remove the user from the format form * Remove out of date view template comments * Use assign for instance variables in template spec, and move to new home --------- Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored-by: Gina Yamada <gina.yamada@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal