Add environment to the body of the monthly key metrics report (LG-11418)#9538
Merged
zachmargolis merged 2 commits intomainfrom Nov 3, 2023
Merged
Add environment to the body of the monthly key metrics report (LG-11418)#9538zachmargolis merged 2 commits intomainfrom
zachmargolis merged 2 commits intomainfrom
Conversation
changelog: Internal, Reporting, Update monthly key metrics report
Contributor
Author
|
re: visual rendering bug I checked with @aduth, he thinks it may be fixed once uswds/uswds#5583 is fixed upstream. Since this alert is internal-only, going to merge as-is and we can fix the bug after that |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11418
🛠 Summary of changes
The email subject lines already have the environment name such as
[prod] Foobar reporthowever GMail likes to collapse multiple environments into the same thread.This PR adds alert content to the body of the email so it's clearer without having to click into subject within a message in a GMail thread.
👀 Screenshots