Avoid appending info for ignored Lograge actions#9544
Merged
Conversation
aduth
force-pushed
the
aduth-lograge-ignore-sessions-controller
branch
from
699cc97 to
1822053
Compare
aduth
force-pushed
the
aduth-avoid-append-lograge-ignored
branch
from
b95da8e to
3adfc08
Compare
aduth
commented
Nov 3, 2023
Contributor
Author
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
To do: Enhance the existing specs.
Base automatically changed from
aduth-lograge-ignore-sessions-controller
to
main
November 6, 2023 13:33
changelog: Internal, Logging, Avoid logging request detail for session active routes
aduth
force-pushed
the
aduth-avoid-append-lograge-ignored
branch
from
3adfc08 to
7bbff66
Compare
mitchellhenke
approved these changes
Nov 6, 2023
Contributor
Author
Added in b0ad17f |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Shortcuts to avoid appending info to a Lograge payload which would be ignored.
Arguably this feels like something that Lograge itself should be doing, but this is the next best thing.
Unfortunately I couldn't find a more direct way to test that the current request should be ignored, but I did try to stay as close to the source implementation as possible (source).
Why does this matter? It helps avoid a database query for the session heartbeat route. See #9541 and #7966 for more context.
📜 Testing Plan
Repeat Testing Plan from #9541 and confirm that there are no logged entries for
User Loaddatabase query on the resulting session active heartbeat requests.