Skip to content

Update Lograge configuration to ignore active ping controller#9541

Merged
aduth merged 1 commit intomainfrom
aduth-lograge-ignore-sessions-controller
Nov 6, 2023
Merged

Update Lograge configuration to ignore active ping controller#9541
aduth merged 1 commit intomainfrom
aduth-lograge-ignore-sessions-controller

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Nov 3, 2023

🛠 Summary of changes

Updates Lograge configuration to ignore the active session polling route introduced in #7966.

Why?

Related Slack discussion: https://gsa-tts.slack.com/archives/C0NGESUN5/p1699041988555609?thread_ts=1699025376.007689&cid=C0NGESUN5

📜 Testing Plan

  1. Build assets with yarn build && yarn build:css
  2. Set short session check delay and frequency in config/application.yml:
    session_check_delay: 0
    session_check_frequency: 1
    
  3. Start server with rails s
  4. Go to http://localhost:3000
  5. Sign in
  6. In terminal, note that you're not seeing any request logging that looks like...
    {"method":"GET","path":"/api/internal/sessions" ...}
    

Note about database queries: The database query for User Load still happens unfortunately, and a binding.pry in ApplicationController#append_info_to_payload indicates that Lograge is still calling append_info_to_payload for these actions despite the fact that they're ignored. It'll be worth checking to see if that's a bug or if some workaround can be made, since it seems unexpected that it would be called. Edit: See #9544.

changelog: Internal, Logging, Avoid logging request detail for session active routes
@aduth aduth force-pushed the aduth-lograge-ignore-sessions-controller branch from 699cc97 to 1822053 Compare November 3, 2023 21:44
@aduth aduth merged commit 2c07328 into main Nov 6, 2023
@aduth aduth deleted the aduth-lograge-ignore-sessions-controller branch November 6, 2023 13:33
@matthinz matthinz mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants