Update Lograge configuration to ignore active ping controller#9541
Merged
Update Lograge configuration to ignore active ping controller#9541
Conversation
mitchellhenke
approved these changes
Nov 3, 2023
changelog: Internal, Logging, Avoid logging request detail for session active routes
699cc97 to
1822053
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates Lograge configuration to ignore the active session polling route introduced in #7966.
Why?
'Users::SessionsController#active'was removed in Avoid database query associated with active session polling #7966)This may actually do the thing that Avoid database query associated with active session polling #7966 intended as far as avoiding a database query for the active session route, which (as I discovered later) wasn't happening as expected due to Lograge-related behaviors applying to the routeEdit: See note below. We're not quite there! Edit 2: See Avoid appending info for ignored Lograge actions #9544 for the quite there.Related Slack discussion: https://gsa-tts.slack.com/archives/C0NGESUN5/p1699041988555609?thread_ts=1699025376.007689&cid=C0NGESUN5
📜 Testing Plan
yarn build && yarn build:cssconfig/application.yml:rails sNote about database queries: The database query for
User Loadstill happens unfortunately, and abinding.pryinApplicationController#append_info_to_payloadindicates that Lograge is still callingappend_info_to_payloadfor these actions despite the fact that they're ignored.It'll be worth checking to see if that's a bug or if some workaround can be made, since it seems unexpected that it would be called.Edit: See #9544.